feat(react-panels): Update ShadowPanel component default to level 3

* Update docs [#84033758] Signed-off-by: Paul Meskers <pmeskers@pivotal.io>
pivotal-cf · Dec 16, 2014 · 7284d7d · 7284d7d
1 parent fd0d231
commit 7284d7d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/pivotal-ui/components/panels.scss b/src/pivotal-ui/components/panels.scss
@@ -730,6 +730,8 @@ parent: panel_react
 ---
 
 ```html_example_table
+<div id="panel-shadow-example-default"></div>
+
 <div id="panel-shadow-example-1"></div>
 
 <div id="panel-shadow-example-2"></div>
@@ -741,22 +743,27 @@ parent: panel_react
 
 ```jsx_example
 React.render(
-  <ShadowPanel shadowLevel="1">Shadow Panel</ShadowPanel>,
+  <ShadowPanel>Shadow Panel (Defaults to shadow level 3)</ShadowPanel>,
+  document.getElementById('panel-shadow-example-default')
+);
+
+React.render(
+  <ShadowPanel shadowLevel="1">Shadow Panel (level 1)</ShadowPanel>,
   document.getElementById('panel-shadow-example-1')
 );
 
 React.render(
-  <ShadowPanel shadowLevel="2">Shadow Panel</ShadowPanel>,
+  <ShadowPanel shadowLevel="2">Shadow Panel (level 2)</ShadowPanel>,
   document.getElementById('panel-shadow-example-2')
 );
 
 React.render(
-  <ShadowPanel shadowLevel="3">Shadow Panel</ShadowPanel>,
+  <ShadowPanel shadowLevel="3">Shadow Panel (level 3)</ShadowPanel>,
   document.getElementById('panel-shadow-example-3')
 );
 
 React.render(
-  <ShadowPanel shadowLevel="4">Shadow Panel</ShadowPanel>,
+  <ShadowPanel shadowLevel="4">Shadow Panel (level 4)</ShadowPanel>,
   document.getElementById('panel-shadow-example-4')
 );
 ```

diff --git a/src/pivotal-ui/javascripts/panels.jsx b/src/pivotal-ui/javascripts/panels.jsx
@@ -71,7 +71,7 @@ var ShadowPanel = React.createClass({
     if (_.contains(this.acceptedShadowLevels, '' + this.props.shadowLevel)) {
       type = "panel-shadow-" + this.props.shadowLevel;
     } else {
-      type = "panel-shadow-1";
+      type = "panel-shadow-3";
     }
 
     return (

diff --git a/test/spec/javascripts/panels_spec.js b/test/spec/javascripts/panels_spec.js
@@ -128,7 +128,7 @@ describe('ShadowPanel', function () {
 
   it('creates a panel with the default shadow class', function() {
     expect($('#container .panel .panel-body')).toContainText('Sup');
-    expect($('#container .panel')).toHaveClass('panel-shadow-1');
+    expect($('#container .panel')).toHaveClass('panel-shadow-3');
   });
 
   describe('when the shadowLevel property is set to an acceptable value', function() {
@@ -159,7 +159,7 @@ describe('ShadowPanel', function () {
     });
 
     it('adds the default shadow level class', function() {
-      expect($('#container .panel')).toHaveClass('panel-shadow-1');
+      expect($('#container .panel')).toHaveClass('panel-shadow-3');
     });
   });
 });