-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install and use neovim by default #186
Conversation
This cushions against the following error, caused by the `vim-go` plugin, which is installed by the vim-config (separate repo): vim-go requires Vim 7.4.1689 or Neovim, but you're using an older version. Please update your Vim for the best vim-go experience. If you really want to continue you can set this to make the error go away: let g:go_version_warning = 0 Note that some features may error out or behave incorrectly. Please do not report bugs unless you're using Vim 7.4.1689 or newer. Also, neovim is faster. Necessary for this, I re-ordered some of the major modules in the main `setup.sh` script so that if we fail halfway through, we don't have configuration which refers to a binary (nvim) that isn't installed yet Reopens and resolves pivotal#93
I like this idea. I’ll give it a try soon. |
Why is this necessary? I just checked two workstations, and |
Well, there are a couple different approaches. Right now we are installing macvim via a Homebrew cask. It looks to me like we fall back to the system vim on the terminal. I bet the version is different based on which OS version you’re on. We could install a newer standard vim via Homebrew, or we could install neovim. I admit I don’t actually know what neovim does differently, but I’ve heard that it’s popular at Pivotal recently. |
With the system vim I wasn't able to use Looking at https://stackoverflow.com/a/11489440 and specifically the following passage:
With system vim, |
On a workstation imaged today with macOS Sierra |
I like this and want to merge it. Unfortunately I realize now that the vim config we include pivotal/vim-config does not set up anything for neovim, so I believe some users would be confused as to why nvim has none of the usual customizations. I want to remedy that first before moving forward. (I maintain that repo, although don't really vim much anymore) There's an issue at pivotal-legacy/vim-config#4. Another option would be to switch to @luan's vim-config which I believe does support neovim. |
We are declaring PR bankruptcy as per #295. Please review recent changes and direction and resubmit if needed. For example, we are are only installing Vim and VSCode by default, leaving others optional. Thank you! |
This cushions against the following error, caused by the
vim-go
plugin, which is installed by the vim-config (separate repo):
Also, neovim is faster.
Necessary for this, I re-ordered some of the major modules in the main
setup.sh
script so that if we fail halfway through, we don't haveconfiguration which refers to a binary (nvim) that isn't installed yet
Reopens and resolves #93
Note the
alias
-- is that how we want to be installing things like this? I'm used to it, but are there cases where it doesn't work well? At initial glance, neovim is doing well to pick up our existing configuration.