Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stream.builder in AsyncParallelCollector #475

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Use Stream.builder in AsyncParallelCollector #475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afc4018
Use Stream.builder in AsyncParallelCollector
pivovarit Mar 29, 2020
e89d114
Use Stream.builder in AsyncParallelCollector
pivovarit Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/main/java/com/pivovarit/collectors/AsyncParallelCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
package com.pivovarit.collectors;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
Expand All @@ -27,7 +26,7 @@
* @author Grzegorz Piwowarek
*/
final class AsyncParallelCollector<T, R, C>
implements Collector<T, List<CompletableFuture<R>>, CompletableFuture<C>> {
implements Collector<T, Stream.Builder<CompletableFuture<R>>, CompletableFuture<C>> {

private final Dispatcher<R> dispatcher;
private final Function<T, R> mapper;
Expand All @@ -45,19 +44,19 @@ private AsyncParallelCollector(
}

@Override
public Supplier<List<CompletableFuture<R>>> supplier() {
return ArrayList::new;
public Supplier<Stream.Builder<CompletableFuture<R>>> supplier() {
return Stream::builder;
}

@Override
public BinaryOperator<List<CompletableFuture<R>>> combiner() {
public BinaryOperator<Stream.Builder<CompletableFuture<R>>> combiner() {
return (left, right) -> {
throw new UnsupportedOperationException();
};
}

@Override
public BiConsumer<List<CompletableFuture<R>>, T> accumulator() {
public BiConsumer<Stream.Builder<CompletableFuture<R>>, T> accumulator() {
return (acc, e) -> {
if (!dispatcher.isRunning()) {
dispatcher.start();
Expand All @@ -67,11 +66,11 @@ public BiConsumer<List<CompletableFuture<R>>, T> accumulator() {
}

@Override
public Function<List<CompletableFuture<R>>, CompletableFuture<C>> finisher() {
public Function<Stream.Builder<CompletableFuture<R>>, CompletableFuture<C>> finisher() {
return futures -> {
dispatcher.stop();

return toCombined(futures)
return toCombined(futures.build())
.thenApply(processor)
.handle((c, ex) -> ex == null ? result.complete(c) : result.completeExceptionally(ex))
.thenCompose(__ -> result);
Expand All @@ -83,12 +82,13 @@ public Set<Characteristics> characteristics() {
return Collections.emptySet();
}

private static <T> CompletableFuture<Stream<T>> toCombined(List<CompletableFuture<T>> futures) {
CompletableFuture<Stream<T>> combined = allOf(futures.toArray(new CompletableFuture[0]))
.thenApply(__ -> futures.stream()
private static <T> CompletableFuture<Stream<T>> toCombined(Stream<CompletableFuture<T>> futures) {
CompletableFuture<T>[] futuresArray = futures.toArray(CompletableFuture[]::new);
CompletableFuture<Stream<T>> combined = allOf(futuresArray)
.thenApply(__ -> Arrays.stream(futuresArray)
.map(CompletableFuture::join));

for (CompletableFuture<T> f : futures) {
for (CompletableFuture<?> f : futuresArray) {
f.exceptionally(ex -> {
combined.completeExceptionally(ex);
return null;
Expand Down