-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency type stubs #651
Conversation
@@ -9,6 +9,8 @@ | |||
from codemodder.diff import create_diff_and_linenums | |||
from codemodder.logging import logger | |||
|
|||
TYPE_CHECKER_LIBRARIES = ["mypy", "pyright"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any others we care to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me overall. I just have a request for an additional unit test case.
Quality Gate passedIssues Measures |
Overview
Add type stubs to our codemodder dependencies (those that have it) and write those stubs in pyproject.toml when poetry is used
Description
testing with pygoat looks like this
Closes #635