Deprecate requesting codemods by name #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andrecsilva
approved these changes
Jul 9, 2024
drdavella
approved these changes
Jul 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Codemods can now only be requested by id
We still have the ability to initialize a codemod by a name, but it's now know that this may not be a unique name since multiple tools could have the same codemod name. So codemods can now only be requested by id.
I changed all important locations, while some locations still use
codemod.name. I also made a wrapper called_internal_nameto indicate that the places we're using that it's for the internal semgrep call.Closes #697
Future work: I can remove the
-semgrepsuffix in the first semgrep codemod I recently added since it's so new, but do we want to also go back and rename all the sonar codemods that have-idsuffix?