Use 1-based line numbers for RegexTransformer changes #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nahsra
approved these changes
Jul 30, 2024
gilday
approved these changes
Jul 30, 2024
| @@ -27,6 +29,7 @@ def apply( | |||
| file_context: FileContext, | |||
| results: list[Result] | None, | |||
| ) -> ChangeSet | None: | |||
| del results | |||
There was a problem hiding this comment.
What's the significance of deleting this reference? Is it to communicate that this parameter is intentionally unused and only exists to satisfy the API requirements of the caller?
There was a problem hiding this comment.
Yes that's right. It makes explicit to the to the type checker that this parameter is intentionally unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.