Transformers should read and write bytes #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clavedeluna
commented
Aug 1, 2024
| @@ -23,14 +23,6 @@ | |||
| from codemodder.semgrep import run as run_semgrep | |||
|
|
|||
|
|
|||
| def update_code(file_path, new_code): | |||
There was a problem hiding this comment.
this was unused, it's defined below in libcst transformer
andrecsilva
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Handling files as bytes and then decoding / encoding will help support windows style newlines
Also since
file_pathis aPathobject we don't need towith open..... That also required some minor testing changes.this should be released as a minor version