Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forgot to change top of class typing #878

Merged
merged 1 commit into from
Oct 14, 2024
Merged

forgot to change top of class typing #878

merged 1 commit into from
Oct 14, 2024

Conversation

clavedeluna
Copy link
Contributor

This made the API not break as it should, since it still made context have an llm_client

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit c2560fc Oct 14, 2024
14 checks passed
@drdavella drdavella deleted the typing branch October 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdavella drdavella drdavella approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clavedeluna @drdavella