[Issue #736] support streaming broadcast join #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bianhq
changed the title
bianhq
changed the title
bianhq
requested changes
Oct 23, 2024
| } | ||
| else if (joinAlgo == JoinAlgorithm.BROADCAST_CHAIN) | ||
| { | ||
| // joinOutputs[i] = InvokerFactory.Instance() |
There was a problem hiding this comment.
Why not support broadcast chain join?
| CompletableFuture<CompletableFuture<? extends Output>[]> smallChildFuture = null; | ||
| if (smallChild != null) | ||
| { | ||
| throw new InterruptedException(); |
There was a problem hiding this comment.
Why not execute the child operator?
| CompletableFuture<CompletableFuture<? extends Output>[]> largeChildFuture = null; | ||
| if (largeChild != null) | ||
| { | ||
| throw new InterruptedException(); |
There was a problem hiding this comment.
Why not execute the child operator?
| if (smallChildFuture != null) | ||
| { | ||
| CompletableFuture<? extends Output>[] smallChildOutputs = smallChildFuture.join(); | ||
| waitForCompletion(smallChildOutputs); |
There was a problem hiding this comment.
For streaming execution, it should not wait for the child operator to complete.
| if (largeChildFuture != null) | ||
| { | ||
| CompletableFuture<? extends Output>[] largeChildOutputs = largeChildFuture.join(); | ||
| waitForCompletion(largeChildOutputs, LargeSideCompletionRatio); |
There was a problem hiding this comment.
For streaming execution, it should not wait for the child operator to complete.
| @@ -0,0 +1,56 @@ | |||
| /* | |||
| * Copyright 2023 PixelsDB. | |||
| @@ -0,0 +1,31 @@ | |||
| package io.pixelsdb.pixels.invoker.vhive; | |||
| @Override | ||
| public CompletableFuture<Output> invoke(Input input) | ||
| { | ||
| // log.info(String.format("invoke BroadcastJoinStreamInput: %s", JSON.toJSONString(input, SerializerFeature.PrettyFormat, SerializerFeature.DisableCircularReferenceDetect))); |
There was a problem hiding this comment.
Remove this log if you do not need it.
| String coordinatorIp = WorkerCommon.getCoordinatorIp(); | ||
| int coordinatorPort = WorkerCommon.getCoordinatorPort(); | ||
| CFWorkerInfo workerInfo = new CFWorkerInfo(ip, port, transId, stageId, "broadcast_join", Collections.emptyList()); | ||
| workerCoordinatorService = new WorkerCoordinateService(coordinatorIp, coordinatorPort); |
There was a problem hiding this comment.
Is workerCoordiantorService used anywhere?
huasiy
force-pushed
the
broadcast_join_stream
branch
4 times, most recently
from
05c5e81 to
598bf72
Compare
huasiy
force-pushed
the
broadcast_join_stream
branch
from
598bf72 to
119fe31
Compare
huasiy
force-pushed
the
broadcast_join_stream
branch
from
e0245f6 to
326949d
Compare
huasiy
force-pushed
the
broadcast_join_stream
branch
from
69805f9 to
cf79158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #736.