-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 6.8 kernel to CI build. Update patch versions of existing kernels #1995
Merged
ddelnano
merged 5 commits into
pixie-io:main
from
ddelnano:ddelnano/add-6.8-kernel-update-patch-versions
Aug 29, 2024
Merged
Add 6.8 kernel to CI build. Update patch versions of existing kernels #1995
ddelnano
merged 5 commits into
pixie-io:main
from
ddelnano:ddelnano/add-6.8-kernel-update-patch-versions
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…artifacts Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…8 and later kernels Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/add-6.8-kernel-update-patch-versions
branch
from
August 27, 2024 14:25
32379df
to
a9a274f
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build/CI changes lgtm.
@oazizi000 can you take a quick look at the bpf test changes?
oazizi000
approved these changes
Aug 29, 2024
ddelnano
added a commit
that referenced
this pull request
Sep 3, 2024
Summary: Update reference to old kernel label since most recent update The 6.1.8 kernel was updated to the latest patch version in #1995. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build without specifying `--//bazel/test_runners/qemu_with_kernel:kernel_version` succeeds Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
added a commit
that referenced
this pull request
Sep 4, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel Builds after #1995 would fail since GitHub would attempt to run the 6.1.8 kernel build, which bazel no longer understands. This also updates the qemu test runner kernel that was incorrectly updated in #1999. I thought I had exercised that default value with my testing, but it didn't trigger that default value. Relevant Issues: N/A Type of change: /kind bugfix Test Plan: GitHub build on #2002 which pulls in the matrix change is no longer failing
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…io#1999) Summary: Update reference to old kernel label since most recent update The 6.1.8 kernel was updated to the latest patch version in pixie-io#1995. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Build without specifying `--//bazel/test_runners/qemu_with_kernel:kernel_version` succeeds Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: df3992f
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel Builds after pixie-io#1995 would fail since GitHub would attempt to run the 6.1.8 kernel build, which bazel no longer understands. This also updates the qemu test runner kernel that was incorrectly updated in pixie-io#1999. I thought I had exercised that default value with my testing, but it didn't trigger that default value. Relevant Issues: N/A Type of change: /kind bugfix Test Plan: GitHub build on pixie-io#2002 which pulls in the matrix change is no longer failing GitOrigin-RevId: 9ae53a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add 6.8 kernel to CI build. Update patch versions of existing kernels
In addition to updating the kernels, I've removed the use of the gs://pixie-dev-public/kernel-build bucket. Please see the changes commit by commit to see them independently.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: bpf-build-all-kernels build should succeed