Revert "Use px/agent_status_diagnostics script within px cli to detect missing kernel headers (#2065)"
#2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/revert-gh-2065
branch
from
8c1bcf0 to
0b8a3c5
Compare
…ect missing kernel headers (pixie-io#2065)" This reverts commit 3c9c4bd. Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/revert-gh-2065
branch
from
0b8a3c5 to
4e812ba
Compare
aimichelle
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Revert "Use
px/agent_status_diagnosticsscript within px cli to detect missing kernel headers (#2065)"This reverts commit 3c9c4bd. While testing the latest cloud release, I noticed that the functionality added in #2065 can cause
px deployto hang indefinitely at the "Wait for healthcheck" step. The deploy will finish successfully, but it's a poor user experience.There seems to be a goroutine blocking issue that is dependent on cluster size. On 1 and 2 node clusters that I tested #2065 on, the issue doesn't surface. However, the issue reproduces reliably on the larger clusters that have pixie deployed to. Let's revert and release a new cli version once this is tracked down.
Relevant Issues: #2051
Type of change: /kind bugfix
Test Plan: N/A
Changelog Message: Reverted the recent advanced diagnostics added during
px deployas in some cases it can cause that causedpx deployto hang