Broken snapshots on CI due to unicode character

[twschiller]

It’s a unicode whitespace issue. If you copy-paste into https://www.soscisurvey.de/tools/view-chars.php you’ll see the diff:

That code is for a:

The differences appear to be in these methods:

• toLocaleTimeString
• toLocaleString

Failure from ParseDate brick:

      Object {
        "local": Object {
          "date": "12/9/2021",
    -     "humanReadable": "12/9/2021, 10:00:00 PM",
    +     "humanReadable": "12/9/2021, 10:00:00 PM",
          "iso8601": "2021-12-09T22:00:00.000-05:00",
    -     "time": "10:00:00 PM",
    +     "time": "10:00:00 PM",
        },
        "utc": Object {
          "date": "12/10/2021",
          "epochMillis": 1639105200000,
          "humanReadable": "Fri, 10 Dec 2021 03:00:00 GMT",
          "iso8601": "2021-12-10T03:00:00.000Z",
    -     "time": "3:00:00 AM",
    +     "time": "3:00:00 AM",
        },
      }

Solution

• Pin engine in package.json to >= 18.13. Or we could pin to >= 18, < 18.3

Related Tickets

• Error Date.toLocaleString() in node 19.0.0 nodejs/node#45171
• Node 18.13 ICU 72 Version Breaking Change Date/Time format nodejs/node#46123
• deps: update ICU to 72.1 nodejs/node#45068

[fregante]

Good find! Let's pin to a recent version. It should be as easy as changing the .nvmrc file and ensuring the team is up to date (as well as updating the snapshots)

[fregante]

I think GitHub is now consistently pulling 18.13 and every single CI test is consistently failing. For this I updated the snapshots in #5010 and set the minimum version to 18.13

This can be changed if undesired (ideally not, this is the future anyway) but I made the change to unblock the 10 PRs waiting for this.