#7228: chrome.sidePanel POC 2

[fregante]

Forked from #7232

I was working on an alternative solution here and I'm posting it here so that we can determine which behavior we prefer. Here for example:

• there's no popup anymore; the button opens the sidebar, always
• the sidebar closes when switching to a tab that doesn't have (matches the MV2 behavior)

Screen.Recording.1.mov

[fregante]

Please don't judge the code yet, I'm just going through every part that fails and it has not been reviewed.

Report

First successful run, however the current sequence is:

1. Open sidebar
2. Reload tab

Also first successful auto-open and update from the page editor:

Screen.Recording.2.mov

[fregante]

The sidebar bricks also already work:

Screen.Recording.3.mov

[fregante]

What happens when this value is lost after a page reload? The sidebar will stop updating until a higher number is reached.

This is another instance of why the content script can no longer be the sidebar controller.

• Move/drop sequence number

[grahamlangford]

If you'd like to review/test, it'd be great to see what's still broken, ideally accompanied by repros. I fixed everything I noticed wrong so far, or added some TODOs inline and in this review.

I'm reviewing your changes now. I'll test it thoroughly today and let you know what I find.

If this instruction has since changed, we can think about merging these changes with the MV2-compatible API.

Unless the complexity of maintaining MV2 + old sidebar alongside MV3 + side panel is high, we'll be keeping both together. So considering how to pull this in in a backwards compatible way makes sense as a next step.

[fregante]

Squashing and reopening into another PR and tracking issue:

• #7228: chrome.sidePanel POC 3 #7320
• Sidebar changes before the sidePanel migration/merge #7319