ACME v2 & saving registration #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalada
commented
May 10, 2019
Closed
jalada
commented
May 17, 2019
| puts "Done!" | ||
| end | ||
|
|
||
| client = Acme::Client.new(private_key: private_key, |
There was a problem hiding this comment.
Add a comment here; why are we remaking the client?
Added comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #59, #60
This PR splits up the great work from @mashedkeyboard in #60, which also includes a stab at DNS-based validations.
Specifically, this PR:
ACME_TERMS_AGREEDenvironment variable which must be set.ACME_ENDPOINTenvironment variable. We never tested this works with anything other than LetsEncrypt, and LetsEncrypt diverges from ACME v2. Also, the clue is in the name of the gem.Pretty much ready to go.