Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for nameStyle option in Manifest #95

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Oct 9, 2024

This PR takes care of bundle name conflicts by adding support of nameStyle property.
Unlike v0.x.x which used complex regex to extract relative name from path, this PR traverses asset tree and generates the relative name without much effort.
Fixes/Closes #87

@Zyie Zyie changed the title feat(manifest): Added support for nameStyle option feat: Added support for nameStyle option in Manifest Oct 9, 2024
Copy link
Member

@Zyie Zyie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CatchABus thanks for doing this, it is great!

@Zyie Zyie merged commit 586f6e6 into pixijs:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect manifest bundle names in v1
2 participants