Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ambient light directionality #29

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

sjlynch
Copy link
Contributor

@sjlynch sjlynch commented Oct 16, 2018

Removes direction from the ambient light fragment shader.

@ivanpopelyshev ivanpopelyshev merged commit d571fa5 into pixijs:master Oct 18, 2018
@ivanpopelyshev
Copy link
Contributor

I agree that ambient shouldn't have direction.

@sjlynch
Copy link
Contributor Author

sjlynch commented Oct 19, 2018

Woo! My first pull request was accepted! Thanks!

I'm going to try to modify this locally to enable multiple sprite layers. Currently if you have multiple containers e.g. ground layer, background layer, sprite layer, foreground layer, etc., the top-most layer is where the lighting is applied. So this causes a lot of issues with my engine -- i'll see if i can create an elegant fix for this. Of course I could just be doing something wrong.

@ivanpopelyshev
Copy link
Contributor

ivanpopelyshev commented Oct 20, 2018

I'm working on a way to make it easier, to use one Sprite for multiple layers instead of container of sprites, each for one layer.

Also, there's "sorting layer" abstraction that i want to make easier: https://pixijs.io/examples/#/layers/normals-drag.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants