-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Type Improvements #522
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 26b969a:
|
I think I broke the typescript type emitting when I attempted to fix the tests, My bad. |
…to satisfy vscode.
replace never with unknown for composition
Pulling For whatever reason, the CodeSanbox still tells me it can not find the types for the module!? 🤷 I'm pretty confident this is finally ready, but I could use your thoughts on the code sandbox issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of change
Refactor and improve Typescript types
Fixes:
Pre-Merge Checklist
npm run lint
)npm run test
)