Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let preferUrl respect supported formats #255

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Let preferUrl respect supported formats #255

merged 1 commit into from
Oct 19, 2023

Conversation

zOadT
Copy link
Contributor

@zOadT zOadT commented Oct 13, 2023

Coincidentally stumbled on this: The second example from here is throwing in Safari (17.0) because it will just try to play the ogg file even though Safari does not support oggs.

It would now throw synchronously if no supported file is found. Previously a Promise got rejected, because the file could not be decoded. Could this change be a problem?

@bigtimebuddy bigtimebuddy merged commit 9f36f77 into pixijs:main Oct 19, 2023
1 check passed
@bigtimebuddy
Copy link
Member

Thanks @zOadT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants