fix: seperate nodes entry for backward compatibility #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yue4u
commented
Jun 27, 2024
yue4u
commented
Jun 27, 2024
yue4u
commented
Jun 27, 2024
| @@ -92,7 +92,7 @@ Code like this: | |||
|
|
|||
| ```javascript | |||
| import * as THREE from 'three'; | |||
| import { GLTFLoader } from 'three/examples/jsm/loaders/GLTFLoader'; | |||
| import { GLTFLoader } from 'three/examples/jsm/loaders/GLTFLoader.js'; | |||
There was a problem hiding this comment.
align to three export
yue4u
commented
Jun 27, 2024
yue4u
commented
Jun 27, 2024
0b5vr
reviewed
Jun 28, 2024
0b5vr
reviewed
Jun 28, 2024
0b5vr
reviewed
Jun 28, 2024
…e-vrm-materials-mtoon/nodes`
Removed `MToonNodeMaterialLoaderPlugin` and introduce `materialType` property to `MToonMaterialLoaderPlugin` Updated README, doc comments, and examples according to the new API
move some of outline procedure to a separated function `_shouldGenerateOutline`
…`, `debugMode` from parameters MToonNodeMaterial does not support these parameters so we delete them
feat: Change the MToonNodeMaterial API
…eorganized deps graph in mtoon-loader
Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
|
webgpu-dnd example now produces a lot of errors when using with an order version of three. Can we do something about this?
|
|
Errors can happen before instantiate MToonNodeMaterial
0b5vr
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address compatibility issues with three before r161.
Removed
export * from './nodes'inthree-vrm-materials-mtoonand created seperated./nodesentry in boththree-vrm-materials-mtoonandthree-vrm