Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: improve prompt for simulated universe & daily training notification #122

Merged
merged 2 commits into from
Jul 10, 2023
Merged

i18n: improve prompt for simulated universe & daily training notification #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ff749f
i18n: improve prompt for simulated universe & daily training notifica…
CanglongCl Jul 8, 2023
81a3142
fix: i18n for english "yet" -> "not yet"
CanglongCl Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Features/Notification/DailyNoteNotification.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,10 @@ private struct DailyNoteNotificationSender {
)
content.body = String(
format: "notification.daily_training.body"
.localized(comment: "%@'s score... / current is %lld"),
.localized(comment: "%@'s score... / current progress is %lld/%lld"),
account.name,
dailyTraining.currentScore
dailyTraining.currentScore,
dailyTraining.maxScore
)

content.badge = 1
Expand Down Expand Up @@ -310,9 +311,10 @@ private struct DailyNoteNotificationSender {
)
content.body = String(
format: "notification.simulated_universe.body"
.localized(comment: "%@'s score... / current is %lld"),
.localized(comment: "%@'s score... / current is %lld/%lld"),
account.name,
simulatedUniverse.currentScore
simulatedUniverse.currentScore,
simulatedUniverse.maxScore
)

content.badge = 1
Expand Down
4 changes: 2 additions & 2 deletions Internationalization/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
"sys.account.force_push.footer" = "This is prepared when syncing via iCloud is not working on your Apple Watch.";
"watch.account.empty" = "Syncing from iCloud";
"notification.daily_training.title" = "Reminder: daily training for %@";
"notification.daily_training.body" = "The daily training score for %@ are not fully utilized. The current count is %lld.";
"notification.daily_training.body" = "The daily training for %@ is not yet completed. The current progress is %lld/%lld.";
"setting.notification.daily_training.toggle" = "Allow Daily Training notifications";
"setting.notification.daily_training.header" = "Daily Training";
"setting.notification.daily_training.date_picker" = "Notify me at";
Expand All @@ -222,7 +222,7 @@
"sys.weekday.friday" = "Friday";
"sys.weekday.saturday" = "Saturday";
"notification.simulated_universe.title" = "Reminder: simulated universe for %@";
"notification.simulated_universe.body" = "The simulated universe score for %@ are not full. The current count is %lld.";
"notification.simulated_universe.body" = "The simulated universe score for %@ is not yet full. The current progress is %lld/%lld.";
"setting.notification.simulated_universe.toggle" = "Allow Simulated Universe notifications";
"setting.notification.simulated_universe.header" = "Simulated Universe";
"setting.notification.simulated_universe.date_picker" = "Notify me at";
Expand Down
4 changes: 2 additions & 2 deletions Internationalization/ja.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
"sys.account.force_push.footer" = "この機能は、Apple WatchでのiCloudアカウント同期が利用できない場合にのみ使用できます。";
"watch.account.empty" = "iCloudから同期中";
"notification.daily_training.title" = "「%@」のデイリー訓練";
"notification.daily_training.body" = "「%@」のデイリー訓練はまだこなしていません。完成した項目数：%lld。";
"notification.daily_training.body" = "「%@」のデイリー訓練はまだ未完成です。現在の進捗状況は：%lld/%lld。";
"setting.notification.daily_training.toggle" = "デイリー訓練の通知をONにする";
"setting.notification.daily_training.header" = "デイリー訓練";
"setting.notification.daily_training.date_picker" = "通知の時間：";
Expand All @@ -222,7 +222,7 @@
"sys.weekday.friday" = "金曜日";
"sys.weekday.saturday" = "土曜日";
"notification.simulated_universe.title" = "「%@」の模擬宇宙";
"notification.simulated_universe.body" = "「%@」の模擬宇宙ポイントはまだこなしていません。 現在のポイントは %lld.";
"notification.simulated_universe.body" = "「%@」の模擬宇宙ポイントはまだ満たしていません。現在の進捗状況は：%lld/%lld。";
"setting.notification.simulated_universe.toggle" = "模擬宇宙の通知をONにする";
"setting.notification.simulated_universe.header" = "模擬宇宙";
"setting.notification.simulated_universe.date_picker" = "通知の時間：";
Expand Down
4 changes: 2 additions & 2 deletions Internationalization/zh-Hans.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
"sys.account.force_push.footer" = "本功能仅当在您的Apple Watch上通过iCloud同步帐号功能不可用时使用。";
"watch.account.empty" = "等待从iCloud同步";
"notification.daily_training.title" = "「%@」每日实训提醒";
"notification.daily_training.body" = "%@的每日实训积分未满，现为%lld。";
"notification.daily_training.body" = "%@的每日实训尚未完成，当前进度为%lld/%lld。";
"setting.notification.daily_training.toggle" = "允许每日实训通知";
"setting.notification.daily_training.header" = "每日实训";
"setting.notification.daily_training.date_picker" = "提醒于";
Expand All @@ -222,7 +222,7 @@
"sys.weekday.friday" = "星期五";
"sys.weekday.saturday" = "星期六";
"notification.simulated_universe.title" = "「%@」模拟宇宙提醒";
"notification.simulated_universe.body" = "%@的模拟宇宙积分未满，现为%lld。";
"notification.simulated_universe.body" = "%@的模拟宇宙积分未满，当前进度为%lld/%lld。";
"setting.notification.simulated_universe.toggle" = "允许模拟宇宙通知";
"setting.notification.simulated_universe.header" = "模拟宇宙";
"setting.notification.simulated_universe.date_picker" = "提醒时间";
Expand Down
4 changes: 2 additions & 2 deletions Internationalization/zh-Hant.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
"sys.account.force_push.footer" = "本功能僅當在您的Apple Watch上通過iCloud同步帳號功能不可用時使用。";
"watch.account.empty" = "等待從iCloud同步";
"notification.daily_training.title" = "「%@」每日實訓提醒";
"notification.daily_training.body" = "%@的每日實訓積分未滿，現為%lld。";
"notification.daily_training.body" = "%@的每日實訓尚未完成，當前進度為%lld/%lld。";
"setting.notification.daily_training.toggle" = "啟用每日實訓通知";
"setting.notification.daily_training.header" = "每日實訓";
"setting.notification.daily_training.date_picker" = "提醒於";
Expand All @@ -222,7 +222,7 @@
"sys.weekday.friday" = "星期五";
"sys.weekday.saturday" = "星期六";
"notification.simulated_universe.title" = "「%@」模擬宇宙提醒";
"notification.simulated_universe.body" = "%@的模擬宇宙積分未滿，現為%lld。";
"notification.simulated_universe.body" = "%@的模擬宇宙積分未滿，當前進度為%lld/%lld。";
"setting.notification.simulated_universe.toggle" = "啟用模拟宇宙通知";
"setting.notification.simulated_universe.header" = "模擬宇宙";
"setting.notification.simulated_universe.date_picker" = "提醒時間";
Expand Down
Loading