Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n // Traditional Chinese translation, etc. #97

Merged
merged 11 commits into from
Jun 1, 2023
Merged

i18n // Traditional Chinese translation, etc. #97

merged 11 commits into from
Jun 1, 2023

Conversation

ShikiSuen
Copy link
Collaborator

@ShikiSuen ShikiSuen commented May 30, 2023

WARNING: Please revert Repo // Remove HSRPizzaHelperWidgetLiveActivity_Previews. before merge. The only reason to remove this is to make sure the project can be compilable using Xcode 14.1.

Caveats: DailyNoteCard has the expedition name untranslated, requiring further discussions regarding how to translate this. If putting the translations of them into the "Localized.strings"file, it will get bloated... I suggest using a dedicated JSON or Plist file to manage them. Also ref: https://github.com/vChewing/Hotenka

@ShikiSuen ShikiSuen self-assigned this May 30, 2023
@ShikiSuen ShikiSuen added the enhancement New feature or request label May 30, 2023
@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

Features/Daily Note/View/InAppDailyNoteCardView.swift Outdated Show resolved Hide resolved
HSRPizzaHelper/View/SettingView.swift Outdated Show resolved Hide resolved
HSRPizzaHelper/View/SettingView.swift Outdated Show resolved Hide resolved
@CanglongCl CanglongCl merged commit 76db796 into dev Jun 1, 2023
@CanglongCl CanglongCl deleted the i18n/cht branch June 1, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants