Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.0 #8

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Release 0.8.0 #8

merged 1 commit into from
Aug 12, 2024

Conversation

pka
Copy link
Owner

@pka pka commented Aug 12, 2024

@michaelkirk Is a minor release ok, or is the reqwest update problematic?

@michaelkirk
Copy link
Contributor

Good question! I'm not the best semantic versioning lawyer.

But I think one litmus test is "can running cargo update break someones build" assuming they have sane version constraints like http-range-client=0.7.2

In this case, I think yes, it could break, right?

Since we're implementing traits on reqwest, and our users might have been using reqwest directly, a patch update to http-range-client could result in them getting an incompatible version of reqwest. Right?

So I think this should be a bump to 0.8.0

@pka pka changed the title Release 0.7.3 Release 0.8.0 Aug 12, 2024
@pka pka merged commit b78be0e into main Aug 12, 2024
6 checks passed
@pka pka deleted the rel-0-7-3 branch August 12, 2024 21:42
@@ -30,6 +30,6 @@ Implements Seek+Read for blocking clients, which makes it a drop-in replacement
* [reqwest](https://crates.io/crates/reqwest) blocking (`reqwest-sync`, default):
Not supported on Wasm target
* [ureq](https://crates.io/crates/ureq) blocking (`ureq-sync`):
Supports native and Wasm target
Not supported on Wasm target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants