This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Introduce Stacktrace and Frame #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
force-pushed
the
stacktrace
branch
4 times, most recently
from
560e9b0
to
33bc92c
Compare
This PR is a continuation of a series aimed at exposing the stack trace information embedded in each error value. The secondary effect is to deprecated the `Fprintf` helper. Taking cues from from @ChrisHines' `stack` package this PR introduces a new interface `Stacktrace() []Frame` and a `Frame` type, similar in function to the `runtime.Frame` type (although lacking its iterator type). Each `Frame` implemnts `fmt.Formatter` allowing it to print itself. The older `Location` interface is still supported but also deprecated.
| fmt.Fprintf(s, "%d", f.line()) | ||
| case 'n': | ||
| name := runtime.FuncForPC(f.pc()).Name() | ||
| i := strings.LastIndex(name, ".") |
There was a problem hiding this comment.
Note that for a method name will look like package-path.type-name.method-name. Using LastIndex(name, ".") excludes the type-name, which would be ambiguous when many methods have the same name. That is why the stack package finds the first . after the last /.
There was a problem hiding this comment.
Thanks. I cheated there. I'll try to write a test case and fix this.
- Handle possible nil in `runtime.FuncForPC` - Refactor trimGOPATH to work on strings, not funcs and pc's - Fix incorrect handling of `%n` for methods.
This was referenced Jun 7, 2016
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of a series aimed at exposing the stack trace
information embedded in each error value. The secondary effect is to
deprecated the
Fprintfhelper.Taking cues from from @ChrisHines'
stackpackage this PR introduces anew interface
Stacktrace() []Frameand aFrametype, similar infunction to the
runtime.Frametype (although lacking its iteratortype). Each
Frameimplemntsfmt.Formatterallowing it to printitself.
The older
Locationinterface is still supported but also deprecated.