Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for the dependency and runtime updates #68

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Prepare for the dependency and runtime updates #68

merged 7 commits into from
Nov 6, 2023

Conversation

dominykas
Copy link
Member

This PR is preparation for the dependency updates and the Node.js upgrade in the action runner itself (will follow up with that in a few minutes):

  • It updates the Node.js release schedule (this will add Node.js 21 as the experimental version into various matrices)
  • It starts using the built-in test runner for the tests for the private actions and refactors them a little bit
  • It removes the GITHUB_OUTPUT env var inside tests - we're testing that we're producing the correct output, but we do not want to affect the actual output. I'll follow this up later to actually set it to a temporary file, so that tests can be further cleaned up to stop hijacking process.stdout.

@dominykas
feat: update Node.js release schedule
e5ccb3e 
(cherry picked from commit 41a3e8e)
@dominykas
test: remove GITHUB_OUTPUT env var during tests
3d05fad 
GITHUB_OUTPUT belongs to the action which executes these tests - we don't want to affect it.

There will be a follow up to set GITHUB_OUTPUT to something temporary, so that we can actually test things end-to-end, under real-life conditions.

(cherry picked from commit 554b17c)
@dominykas
test: modernize prepare-dynamic-steps tests to use node:test
53bb3af 
(cherry picked from commit 8b89dd8)
@dominykas
test: modernize prepare-node-test-matrix-action tests to use node:test
7b2bf10 
(cherry picked from commit 177e435)
@dominykas
refactor: modernize
299f9ad 
(cherry picked from commit c0bc1dc)
@dominykas
test: change assertions to remove the github ::set-output prefix
f707e47 
This will make it simpler to refactor the tests to rely on GITHUB_OUTPUT variable again, instead of hijacking the stdout.

(cherry picked from commit ebed8de)
@dominykas dominykas mentioned this pull request Nov 1, 2023
Merged
@dominykas dominykas changed the title Prepare the upgrade to use node20 in the action runner Prepare for the dependency and runtime updates Nov 1, 2023
Eomm
Eomm approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

.github/actions/prepare-node-test-matrix-action/index.js Outdated Show resolved Hide resolved
@dominykas @Eomm
Update .github/actions/prepare-node-test-matrix-action/index.js
b70b07f 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@dominykas dominykas merged commit e462000 into main Nov 6, 2023
4 checks passed
@dominykas dominykas deleted the modernize branch November 6, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominykas @Eomm