Skip to content

Commit

Permalink
chore: deprecate node 10 and 12
Browse files Browse the repository at this point in the history
BREAKING CHANGE: dropping support for old versions of node. This is primarily because npm@8 no longer works on node@10, which complicates the CI scripts unnecessarily.
  • Loading branch information
dominykas committed Jan 31, 2022
1 parent f4b0cfb commit 49bcab2
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: node_js

import:
- nodejs/ci-config-travis:lts/gte-10.yml
- nodejs/ci-config-travis:lts/gte-14.yml

cache:
npm: false
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"url": "https://github.com/pkgjs/detect-node-support/issues"
},
"engines": {
"node": ">=10"
"node": ">=14"
},
"homepage": "https://github.com/pkgjs/detect-node-support#readme",
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion test/fixtures/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ module.exports = class TestContext {

Nock('https://api.github.com')
.persist()
.get('/repos/nodejs/ci-config-travis/contents/lts%2Fgte-10.yml')
.get('/repos/nodejs/ci-config-travis/contents/lts%2Fgte-14.yml')
.reply(200, {
// note: this is mocked out to an earlier version of node, to avoid having to update too many assertions/fixtures
content: Fs.readFileSync(Path.join(__dirname, 'travis-ymls', 'nodejs-ci-config-travis-gte-10.yml')).toString('base64')
});

Expand Down
24 changes: 12 additions & 12 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -454,7 +454,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -491,7 +491,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand All @@ -518,7 +518,7 @@ describe('detect-node-support', () => {
version: '0.0.0-development',
commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
timestamp: 1580673602000,
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -621,7 +621,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -686,7 +686,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -717,7 +717,7 @@ describe('detect-node-support', () => {
version: '0.0.0-development',
commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
timestamp: 1580673602000,
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -815,7 +815,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -865,7 +865,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -902,7 +902,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -939,7 +939,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down Expand Up @@ -980,7 +980,7 @@ describe('detect-node-support', () => {
'14': '14.3.0'
}
},
engines: '>=10'
engines: '>=14'
});
});

Expand Down

0 comments on commit 49bcab2

Please sign in to comment.