Replace got with fetch #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
commented
Jul 16, 2024
| "semver": "^7.1.1", | ||
| "yargs": "^16.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^20.14.11", |
There was a problem hiding this comment.
There was in implicit dependency on these types which was satisfied by bringing in got. Why it had it as a prod dep I don't think I understand, but removing got broke the type generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the tests pass and it all seems fine, the
cachekey used to be aMapforgotto use. Now it is just a simple in memory lookup. Same api to pass, but technically someone could have been looking at the contents of the map they passed in, so this could break them so marking it as major.