Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use undici instead of node-fetch #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjohansebas
Copy link
Contributor

node-fetch is replaced with undici, it might save some time during CI.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this, but I do wonder if this use case would be better with just fetch from node (which is undici under the hood) to remove the dep. We dont really need the perf or features of the lower level apis.

Not really a big deal, I would merge this and just forget about it just as quickly as substituting in fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants