Skip to content

Commit

Permalink
feat: clean PR
Browse files Browse the repository at this point in the history
add TODO noting that the run checks could be > 1 for a branch
and that some could pass and some could fail and we need to
handle that case
  • Loading branch information
ghinks committed Apr 28, 2021
1 parent 4900188 commit 2c56d47
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/closePR.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const closeDependencyPR = module.exports.closeDependencyPR = async function clos
if (!checkRuns) {
return
}
// TODO, in reality multiple checks could exist and they may not all have passed
const prsToClose = checkRuns.reduce((acc, check) => {
if (check.status === 'completed' &&
check.conclusion === 'success' &&
Expand Down

0 comments on commit 2c56d47

Please sign in to comment.