feat: clean PR

updates to names and suggestions from feedback
pkgjs · Apr 18, 2021 · 49d752f · 49d752f
1 parent e143667
commit 49d752f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/closePR.js b/lib/closePR.js
@@ -25,7 +25,7 @@ module.exports = async ({ dependents }) => {
 }
 
 const closeDependencyPR = module.exports.closeDependencyPR = async function closeDependencyPR (owner, repo, branch, checkRuns) {
-  if (!checkRuns || checkRuns.length === 0) {
+  if (!checkRuns) {
     return
   }
   const prsToClose = checkRuns.reduce((acc, check) => {

diff --git a/lib/test.js b/lib/test.js
@@ -62,7 +62,7 @@ async function pushPatch (dependentPkgJson, dependentOwner, dependentRepo, paren
   debug(`Changes pushed to https://github.com/${dependentOwner}/${dependentRepo}/blob/${branch}/package.json`)
 }
 
-const createPR = module.exports.closePR = async function closePR (dependentOwner, dependentRepo, parentBranchName, parentDependencyLink) {
+const createPR = module.exports.createPR = async function createPR (dependentOwner, dependentRepo, parentBranchName, parentDependencyLink) {
   const title = `Wiby changes to ${parentDependencyLink}`
   const body = `Wiby has raised this PR to kick off automated jobs.
   You are dependent upon ${parentDependencyLink}

diff --git a/test/test.js b/test/test.js
@@ -107,7 +107,7 @@ tap.test('wiby.test()', async (tap) => {
     const dependentOwner = 'pkgjs'
     const dependentRepo = 'wiby'
     const parentBranchName = 'main'
-    wiby.test.closePR(dependentOwner, dependentRepo, parentBranchName)
+    wiby.test.createPR(dependentOwner, dependentRepo, parentBranchName)
       .then((result) => {
         t.equal(result.data.html_url, htmlURL)
         t.end()