Skip to content

Commit

Permalink
issue #75: add tag MNI
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 18, 2020
1 parent aaf2de6 commit 09cd295
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
690, 692, 852$a (code list), 859, 909, 916, 917, 945, 950, 954, 955, 957, 959, 960,
961, 962, 963, 964, 966, 968, 970, 975, 976, 979, 980, 985, 990, 992, 996, 997,
A02, AQN, BGT, BUF, CFI, CNF, DGM, DRT, EST, EXP, FFP, FIN, LAS, LCS, LDO, LEO, LET,
MIS
MIS, MNI

Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;
import de.gwdg.metadataqa.marc.definition.general.validator.ISSNValidator;

/**
* Medium-Neutral Identifier
*/
public class TagMNI extends DataFieldDefinition {

private static TagMNI uniqueInstance;

private TagMNI() {
initialize();
postCreation();
}

public static TagMNI getInstance() {
if (uniqueInstance == null)
uniqueInstance = new TagMNI();
return uniqueInstance;
}

private void initialize() {

tag = "MNI";
label = "Medium-Neutral Identifier";
mqTag = "MediumNeutralIdentifier";
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();

ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Medium-neutral identifier", "NR"
);

getSubfield("a")
.setValidator(ISSNValidator.getInstance())
.setMqTag("mediumNeutralIdentifier");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import org.junit.Test;

public class TagMNITest extends BLTagTest {

public TagMNITest() {
super(TagMNI.getInstance());
}

@Test
public void testValidFields() {
validField("a", "0894-069X");
}

@Test
public void testInvalidFields() {
invalidField("1", "a", "Y");
invalidField("e", "20050944");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(383, tags.size());
assertEquals(384, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit 09cd295

Please sign in to comment.