Skip to content

Commit

Permalink
issue #75: add tag 594
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 7, 2020
1 parent 6f60e3c commit 235a6de
Show file tree
Hide file tree
Showing 4 changed files with 110 additions and 3 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@

### Added

- British Library tags: 039, 091, 509, 539, 590,
591, 592
- British Library tags: 039, 091, 509, 539, 590, 591, 592, 594
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;
import de.gwdg.metadataqa.marc.definition.general.validator.RegexValidator;

/**
* National Bibliography Issue Number
*/
public class Tag594 extends DataFieldDefinition {

private static Tag594 uniqueInstance;

private Tag594() {
initialize();
postCreation();
}

public static Tag594 getInstance() {
if (uniqueInstance == null)
uniqueInstance = new Tag594();
return uniqueInstance;
}

private void initialize() {

tag = "594";
label = "Reference to Items in Printed Catalogues";
mqTag = "referenceToItemsInPrintedCatalogues";
cardinality = Cardinality.Repeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();
ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Note of earliest British Library edition", "NR",
"b", "Reference to items in printed catalogues", "NR"
);

getSubfield("a")
.setValidator(new RegexValidator("^.*\\.$"))
.setMqTag("note");

getSubfield("b")
.setValidator(new RegexValidator("^.*\\.$"))
.setMqTag("reference");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import de.gwdg.metadataqa.marc.MarcRecord;
import de.gwdg.metadataqa.marc.definition.MarcVersion;
import org.junit.Test;

import static junit.framework.TestCase.assertFalse;
import static junit.framework.TestCase.assertTrue;

public class Tag594Test {

@Test
public void testValidFields() {
validField("a", "First BL ed.");
validField("b", "114.");
validField("b", "tys.");
}

@Test
public void testInvalidFields() {
invalidField("c", "NLS copy dimensions: 16 cm.");
invalidField("1", "a", "NLS copy dimensions: 16 cm.");
}

public void validField(String subfield, String value) {
DataField field = new DataField(Tag594.getInstance(), " ", " ", subfield, value);

MarcRecord record = new MarcRecord("test");
field.setRecord(record);

assertFalse(
String.format("594$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertTrue(
String.format("594$%s=%s should be valid in normal case", subfield, value),
field.validate(MarcVersion.BL));
}

public void invalidField(String subfield, String value) {
invalidField(" ", subfield, value);
}

public void invalidField(String ind1, String subfield, String value) {
DataField field = new DataField(Tag594.getInstance(), ind1, " ", subfield, value);

MarcRecord record = new MarcRecord("test");
field.setRecord(record);

assertFalse(
String.format("594$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertFalse(
String.format("594$%s=%s should be invalid in BL", subfield, value),
field.validate(MarcVersion.BL));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(330, tags.size());
assertEquals(331, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit 235a6de

Please sign in to comment.