Skip to content

Commit

Permalink
issue #75: add tag OBJ
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 18, 2020
1 parent 1c6aa9b commit 53651c5
Show file tree
Hide file tree
Showing 5 changed files with 70 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
690, 692, 852$a (code list), 859, 909, 916, 917, 945, 950, 954, 955, 957, 959, 960,
961, 962, 963, 964, 966, 968, 970, 975, 976, 979, 980, 985, 990, 992, 996, 997,
A02, AQN, BGT, BUF, CFI, CNF, DGM, DRT, EST, EXP, FFP, FIN, LAS, LCS, LDO, LEO, LET,
MIS, MNI, MPX, NEG, NID
MIS, MNI, MPX, NEG, NID, OBJ

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ private void initialize() {
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");
obsolete = true;

ind1 = new Indicator();

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;

/**
* Digital Object Field
*/
public class TagOBJ extends DataFieldDefinition {

private static TagOBJ uniqueInstance;

private TagOBJ() {
initialize();
postCreation();
}

public static TagOBJ getInstance() {
if (uniqueInstance == null)
uniqueInstance = new TagOBJ();
return uniqueInstance;
}

private void initialize() {

tag = "OBJ";
label = "Digital Object Field";
mqTag = "DigitalObjectField";
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();

ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Code", "NR"
);

getSubfield("a")
.setCodes("Y", "Y")
.setMqTag("code");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import org.junit.Test;

public class TagOBJTest extends BLTagTest {

public TagOBJTest() {
super(TagOBJ.getInstance());
}

@Test
public void testValidFields() {
validField("a", "Y");
}

@Test
public void testInvalidFields() {
invalidField("1", "a", "Y");
invalidField("a", "X");
invalidField("b", "Y");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(387, tags.size());
assertEquals(388, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit 53651c5

Please sign in to comment.