Skip to content

Commit

Permalink
issue #75: add tag 954
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 8, 2020
1 parent 710603d commit 886b74f
Show file tree
Hide file tree
Showing 4 changed files with 68 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
### Added

- British Library tags: 039, 091, 509, 539, 590, 591, 592, 594, 595, 596, 597, 598, 599,
690, 692, 852$a (code list), 859, 909, 916, 917, 945, 950
690, 692, 852$a (code list), 859, 909, 916, 917, 945, 950, 954
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;

/**
* Transliteration Statement
*/
public class Tag954 extends DataFieldDefinition {

private static Tag954 uniqueInstance;

private Tag954() {
initialize();
postCreation();
}

public static Tag954 getInstance() {
if (uniqueInstance == null)
uniqueInstance = new Tag954();
return uniqueInstance;
}

private void initialize() {

tag = "954";
label = "Transliteration Statement";
mqTag = "transliteration";
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();

ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Transliteration statement", "NR"
);

getSubfield("a").setMqTag("transliteration");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import org.junit.Test;

public class Tag954Test extends BLTagTest {

public Tag954Test() {
super(Tag954.getInstance());
}

@Test
public void testValidFields() {
validField("a", "Greek title transliterated");
validField("a", "Hebrew word in title transliterated");
}

@Test
public void testInvalidFields() {
invalidField("2", "a", "Priority processing");
invalidField("b", "Priority processing");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(344, tags.size());
assertEquals(345, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit 886b74f

Please sign in to comment.