-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
issue #75: implementing 'disallow in schema' feature
- Loading branch information
Showing
8 changed files
with
175 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 3 additions & 8 deletions
11
src/main/java/de/gwdg/metadataqa/marc/definition/tags/bltags/package-info.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
src/test/java/de/gwdg/metadataqa/marc/definition/tags/bltags/Tag037Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
package de.gwdg.metadataqa.marc.definition.tags.bltags; | ||
|
||
import de.gwdg.metadataqa.marc.DataField; | ||
import de.gwdg.metadataqa.marc.MarcRecord; | ||
import de.gwdg.metadataqa.marc.definition.MarcVersion; | ||
import de.gwdg.metadataqa.marc.definition.tags.tags01x.Tag037; | ||
import org.junit.Test; | ||
|
||
import static junit.framework.TestCase.assertFalse; | ||
import static junit.framework.TestCase.assertTrue; | ||
|
||
public class Tag037Test { | ||
|
||
@Test | ||
public void testDisallowedSubfield_c() { | ||
MarcRecord record = new MarcRecord("test"); | ||
DataField field = new DataField(Tag037.getInstance(), " ", " ", "c", "$175.00"); | ||
field.setRecord(record); | ||
|
||
assertTrue("037$c should be valid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertFalse("037$c should be invalid in BL", field.validate(MarcVersion.BL)); | ||
} | ||
|
||
@Test | ||
public void testDisallowedSubfield_f() { | ||
MarcRecord record = new MarcRecord("test"); | ||
DataField field = new DataField(Tag037.getInstance(), " ", " ", "f", "paperbound"); | ||
field.setRecord(record); | ||
|
||
assertTrue("037$f should be valid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertFalse("037$f should be invalid in BL", field.validate(MarcVersion.BL)); | ||
} | ||
|
||
@Test | ||
public void testDisallowedSubfield_g() { | ||
MarcRecord record = new MarcRecord("test"); | ||
DataField field = new DataField(Tag037.getInstance(), " ", " ", "g", "paperbound"); | ||
field.setRecord(record); | ||
|
||
assertTrue("037$g should be valid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertFalse("037$g should be invalid in BL", field.validate(MarcVersion.BL)); | ||
} | ||
|
||
@Test | ||
public void testDisallowedSubfield_6() { | ||
MarcRecord record = new MarcRecord("test"); | ||
DataField field = new DataField(Tag037.getInstance(), " ", " ", "6", "100-01/(N"); | ||
field.setRecord(record); | ||
|
||
assertTrue("037$6 should be valid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertFalse("037$6 should be invalid in BL", field.validate(MarcVersion.BL)); | ||
} | ||
|
||
@Test | ||
public void testDisallowedSubfield_8() { | ||
MarcRecord record = new MarcRecord("test"); | ||
DataField field = new DataField(Tag037.getInstance(), " ", " ", "8", "1.5\\a"); | ||
field.setRecord(record); | ||
|
||
assertTrue("037$8 should be valid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertFalse("037$8 should be invalid in BL", field.validate(MarcVersion.BL)); | ||
} | ||
} |
53 changes: 53 additions & 0 deletions
53
src/test/java/de/gwdg/metadataqa/marc/definition/tags/bltags/Tag039Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package de.gwdg.metadataqa.marc.definition.tags.bltags; | ||
|
||
import de.gwdg.metadataqa.marc.DataField; | ||
import de.gwdg.metadataqa.marc.MarcRecord; | ||
import de.gwdg.metadataqa.marc.definition.MarcVersion; | ||
import org.junit.Test; | ||
|
||
import java.util.regex.Pattern; | ||
|
||
import static junit.framework.TestCase.assertFalse; | ||
import static junit.framework.TestCase.assertTrue; | ||
|
||
public class Tag039Test { | ||
|
||
@Test | ||
public void testRegex() { | ||
assertTrue(Pattern.compile("^\\d\\d(\\d{2}|0[1-3])$").matcher("1785").matches()); | ||
} | ||
|
||
@Test | ||
public void testFieldDefinition() { | ||
validateField("0", "a", "1785"); | ||
validateField("0", "a", "8901"); | ||
validateField("1", "a", "8903"); | ||
validateField("0", "a", "1754"); | ||
validateField("0", "a", "9602"); | ||
validateField(new DataField(Tag039.getInstance(), "0", " ", "p", "1627", "a", "1608")); | ||
validateField("0", "a", "8901"); | ||
validateField("1", "a", "8903"); | ||
} | ||
|
||
public void validateField(String ind1, String subfield, String value) { | ||
DataField field = new DataField(Tag039.getInstance(), ind1, " ", subfield, value); | ||
|
||
MarcRecord record = new MarcRecord("test"); | ||
field.setRecord(record); | ||
|
||
assertFalse( | ||
String.format("039$%s=%s should be invalid in normal case", subfield, value), | ||
field.validate(MarcVersion.MARC21)); | ||
assertTrue( | ||
String.format("039$%s=%s should be valid in normal case", subfield, value), | ||
field.validate(MarcVersion.BL)); | ||
} | ||
|
||
public void validateField(DataField field) { | ||
MarcRecord record = new MarcRecord("test"); | ||
field.setRecord(record); | ||
|
||
assertFalse("039 should be invalid in normal case", field.validate(MarcVersion.MARC21)); | ||
assertTrue("039 should be valid in normal case", field.validate(MarcVersion.BL)); | ||
} | ||
} |