Skip to content

Commit

Permalink
issue #75: add tag 916
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 7, 2020
1 parent a2e0e04 commit ac469fb
Show file tree
Hide file tree
Showing 7 changed files with 72 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
### Added

- British Library tags: 039, 091, 509, 539, 590, 591, 592, 594, 595, 596, 597, 598, 599,
690, 692, 852$a (code list), 859, 909
690, 692, 852$a (code list), 859, 909, 916
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private void initialize() {

tag = "909";
label = "Awaiting OCLC Upgrade";
mqTag = "digitalResourceFlag";
mqTag = "awaitingOclcUpgrade";
cardinality = Cardinality.Repeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;
import de.gwdg.metadataqa.marc.definition.general.validator.RegexValidator;

/**
* Authority Control Information
*/
public class Tag916 extends DataFieldDefinition {

private static Tag916 uniqueInstance;

private Tag916() {
initialize();
postCreation();
}

public static Tag916 getInstance() {
if (uniqueInstance == null)
uniqueInstance = new Tag916();
return uniqueInstance;
}

private void initialize() {

tag = "916";
label = "Authority Control Information";
mqTag = "authorityControl";
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();

ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Authority control information", "R"
);

getSubfield("a")
.setValidator(new RegexValidator("^.*[^\\.]$"))
.setMqTag("authorityControl");
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import de.gwdg.metadataqa.marc.definition.MarcVersion;
import de.gwdg.metadataqa.marc.definition.SubfieldDefinition;
import de.gwdg.metadataqa.marc.definition.tags.tags84x.Tag852;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import org.junit.Test;

public class Tag909Test extends BLTagTest {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import org.junit.Test;

public class Tag916Test extends BLTagTest {

public Tag916Test() {
super(Tag916.getInstance());
}

@Test
public void testValidFields() {
validField(new DataField(tag, " ", " ", "a", "100=NOTNACO", "a", "700/2=NOTNACO"));
}

@Test
public void testInvalidFields() {
invalidField("a", "949573831.");
invalidField("b", "Awaiting upgrade with OCLC record – 20180123.");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(340, tags.size());
assertEquals(341, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit ac469fb

Please sign in to comment.