Skip to content

Commit

Permalink
issue #75: add tag 597
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 7, 2020
1 parent b66674b commit b3fb679
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

### Added

- British Library tags: 039, 091, 509, 539, 590, 591, 592, 594, 595, 596
- British Library tags: 039, 091, 509, 539, 590, 591, 592, 594, 595, 596, 597
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;

/**
* National Bibliography Issue Number
*/
public class Tag597 extends DataFieldDefinition {

private static Tag597 uniqueInstance;

private Tag597() {
initialize();
postCreation();
}

public static Tag597 getInstance() {
if (uniqueInstance == null)
uniqueInstance = new Tag597();
return uniqueInstance;
}

private void initialize() {

tag = "597";
label = "Editing or Error Message";
mqTag = "editingOrErrorMessage";
cardinality = Cardinality.Repeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();
ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Unconverted legacy field or Message relating to conversion, deduplication and enhancement", "NR",
"b", "Information relating to record enhancement", "NR"
);

getSubfield("a")
.setMqTag("legacyFieldOrMessage");

getSubfield("b")
.setMqTag("recordEnhancement");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import org.junit.Test;

public class Tag597Test extends BLTagTest {

public Tag597Test() {
super(Tag597.getInstance());
}

@Test
public void testValidFields() {
validField("a", "MP13/700");
validField("b", "ISSN");
validField(new DataField(tag, " ", " ", "a", "Enhanced", "b", "ISSN"));
}

@Test
public void testInvalidFields() {
invalidField("c", "NLS copy dimensions: 16 cm.");
invalidField("1", "a", "NLS copy dimensions: 16 cm.");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(333, tags.size());
assertEquals(334, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit b3fb679

Please sign in to comment.