Skip to content

Commit

Permalink
issue #75: add tag 539
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 7, 2020
1 parent 9870c1c commit d522e61
Show file tree
Hide file tree
Showing 3 changed files with 107 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;
import de.gwdg.metadataqa.marc.definition.general.validator.RegexValidator;

/**
* National Bibliography Issue Number
*/
public class Tag539 extends DataFieldDefinition {

private static Tag539 uniqueInstance;

private Tag539() {
initialize();
postCreation();
}

public static Tag539 getInstance() {
if (uniqueInstance == null)
uniqueInstance = new Tag539();
return uniqueInstance;
}

private void initialize() {

tag = "539";
label = "Location of Filmed Copy (ESTC)";
mqTag = "locationOfFilmedCopyESTC";
cardinality = Cardinality.Repeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();
ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Location", "NR"
);

getSubfield("a")
.setValidator(new RegexValidator("^.*\\.$"))
.setMqTag("location");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public void validField(String subfield, String value) {
field.setRecord(record);

assertFalse(
String.format("039$%s=%s should be invalid in normal case", subfield, value),
String.format("509$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertTrue(
String.format("039$%s=%s should be valid in normal case", subfield, value),
String.format("509$%s=%s should be valid in normal case", subfield, value),
field.validate(MarcVersion.BL));
}

Expand All @@ -48,10 +48,10 @@ public void invalidField(String ind1, String subfield, String value) {
field.setRecord(record);

assertFalse(
String.format("039$%s=%s should be invalid in normal case", subfield, value),
String.format("509$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertFalse(
String.format("039$%s=%s should be invalid in BL", subfield, value),
String.format("509$%s=%s should be invalid in BL", subfield, value),
field.validate(MarcVersion.BL));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.DataField;
import de.gwdg.metadataqa.marc.MarcRecord;
import de.gwdg.metadataqa.marc.definition.MarcVersion;
import org.junit.Test;

import static junit.framework.TestCase.assertFalse;
import static junit.framework.TestCase.assertTrue;

public class Tag539Test {

@Test
public void testValidFields() {
validField("a", "O.");
validField("a", "L.");
}

@Test
public void testInvalidFields() {
invalidField("b", "NLS copy dimensions: 16 cm.");
invalidField("1", "a", "NLS copy dimensions: 16 cm.");
invalidField("a", "L");
}

public void validField(String subfield, String value) {
DataField field = new DataField(Tag539.getInstance(), " ", " ", subfield, value);

MarcRecord record = new MarcRecord("test");
field.setRecord(record);

assertFalse(
String.format("539$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertTrue(
String.format("539$%s=%s should be valid in normal case", subfield, value),
field.validate(MarcVersion.BL));
}

public void invalidField(String subfield, String value) {
invalidField(" ", subfield, value);
}

public void invalidField(String ind1, String subfield, String value) {
DataField field = new DataField(Tag539.getInstance(), ind1, " ", subfield, value);

MarcRecord record = new MarcRecord("test");
field.setRecord(record);

assertFalse(
String.format("539$%s=%s should be invalid in normal case", subfield, value),
field.validate(MarcVersion.MARC21));
assertFalse(
String.format("539$%s=%s should be invalid in BL", subfield, value),
field.validate(MarcVersion.BL));
}
}

0 comments on commit d522e61

Please sign in to comment.