Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct server instance for playlist items #1463

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

JonnyWong16
Copy link
Collaborator

Description

Sets the correct _server object for playlist items from a different server than the playlist source.

Closes #1461

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 marked this pull request as ready for review September 9, 2024 00:15
@JonnyWong16
Copy link
Collaborator Author

@glensc Can you test this PR?

It works but definitely slows down retrieving playlist items if they are from different servers.

@JonnyWong16 JonnyWong16 merged commit 99205d3 into pkkid:master Nov 16, 2024
5 checks passed
@JonnyWong16 JonnyWong16 deleted the bugfix/playlist_server branch November 16, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant