Common problems with Pull Requests

Jump to bottom Edit New page

pkozlowski-opensource edited this page Nov 17, 2012 · 1 revision

No tests
No documentation changes
Commits not squashed (multiple commits for the same bug fix / feature)
Commit message doesn't follow the convention
CLA not signed
Impossible to merge (git merge conflicts)
Code not well formatted (would be great to get the formatter for WebStorm / sublime / whatever other tools AngularJS team is using)