Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent authors from editing submission metadata and galleys after a submisson is rejected #10486

Open
alexxxmendonca opened this issue Oct 1, 2024 · 2 comments
Open

Prevent authors from editing submission metadata and galleys after a submisson is rejected #10486

alexxxmendonca opened this issue Oct 1, 2024 · 2 comments

Comments

@alexxxmendonca
Copy link
Contributor

alexxxmendonca commented Oct 1, 2024 •
edited
Loading

Describe the bug
After a submission is rejected, autors are able to edit submission metadata and galleys. They can remove and add authors freely and remove PDF files as shown in this History:

image

To Reproduce
Steps to reproduce the behavior:

  1. Reject any submission
  2. Login as the author of that submission
  3. Notice how as the author you can edit the metadata (add/delete authors) and add/delete galleys.

There are undesired consequences such as losing record of the manuscript files, authors associated to that submission and moreover, plugins such as the Author History (https://github.com/lepidus/authorsHistory) is unabled to fetch the data since it's been removed from the database, making the results shown by the plugin to be faulty. Moreover, this negatively affects statistics as well.

What application are you using?
Open Preprint Systems 3.3.0.14

This is what the submission looks like after all the exclusions:
image

image
image
@alexxxmendonca alexxxmendonca changed the title Authors are able to edit submission metadata and galleys even after a submisson is rejected Prevent authors from editing submission metadata and galleys after a submisson is rejected Oct 1, 2024
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Dec 11, 2024
@YvesLepidus
pkp#10486 adds validation to prevent an author of a rejected submissi…
7e5959d 
…on from editing metadata in the submission.

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Dec 12, 2024
@YvesLepidus
pkp#10486 renames the variable $isAuthorOfTheSubmission to $userIsAuthor
5df4624 
Signed-off-by: yves <yves@lepidus.com.br>
@YvesLepidus YvesLepidus mentioned this issue Dec 12, 2024
Open
@YvesLepidus
Copy link
Contributor

I made an implementation proposal to fix this issue in this PR.

YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Dec 12, 2024
@YvesLepidus
pkp#10486 changes parameter of canEditPublication method to receive…
4a08436 
… a Submission object instead of a submission identifier and updates calls to this method.

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/omp that referenced this issue Dec 12, 2024
@YvesLepidus
pkp/pkp-lib#10486 updates canEditPublication method call to pass Su…
bd79bfb 
…bmission object instead of submission identifier.

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/ops that referenced this issue Dec 12, 2024
@YvesLepidus
pkp/pkp-lib#10486 Updates canEditPublication method call to pass Su…
d1d826c 
…bmission object instead of submission identifier.

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Dec 13, 2024
@YvesLepidus
pkp#10486 adds a check if the user is not an manager, applying the me…
e49e800 
…tadata editing restriction only to these cases.

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Dec 18, 2024
@YvesLepidus
pkp#10486 The restriction is only applied if the author has the exclu…
2819c8e 
…sive role of author/reader

Signed-off-by: yves <yves@lepidus.com.br>
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Jan 27, 2025
@YvesLepidus
pkp#10486 changes the retrieval of the Context object to not use Requ…
8c9910d 
…est as a reference.
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Jan 27, 2025
@YvesLepidus
pkp#10486 changes the retrieval of the Context object to not use Requ…
1c03478 
…est as a reference.
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Jan 27, 2025
@YvesLepidus
pkp#10486 removes the true return when the author has a different rol…
bc5e628 
…e from author/reader.
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Jan 28, 2025
@YvesLepidus
pkp#10486 adds code that optimizes the retrieval of the Context ident…
2757b51 
…ifier (it was previously excluded).
@asmecher
Copy link
Member

Thanks, @YvesLepidus! I've made a few more comments on your PR.

YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Feb 4, 2025
@YvesLepidus
pkp#10486 fix context retrieval using the conditional that validates …
6c31032 
…whether the context of the request is the same as the context of the submission.
YvesLepidus added a commit to lepidus/pkp-lib that referenced this issue Feb 4, 2025
@YvesLepidus
pkp#10486 fix context retrieval using the conditional that validates …
c7402c4 
…whether the context of the request is the same as the context of the submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asmecher @alexxxmendonca @YvesLepidus