-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address invalid localization files #8081
Comments
Currently translated at 100.0% (92 of 92 strings) Translation: Open Preprint Systems/locale Translate-URL: http://translate.pkp.sfu.ca/projects/ops/locale/en_US/
…ated locale keys in a given language)
…ated locale keys in a given language)
@asmecher I've created a PR for the I've added a generic validator for the locale files, and most of the fixes are to satisfy the requirements and warnings of the I've tried to isolate the commits, except the 4f379aa... There I used the If everything sounds fine, I'll update the other branches. p.s.: I'm able to reduce the line-break noise by doing a small change to the |
For the I also think it's ok to add the validate-locale.sh in a non-breaking way (e.g. emit errors without failing the build) |
Please hold off on this until we've reached a decision about translation workflows on this discussion: #8038 |
Ok! So I'll just commit fixes for the broken keys (e.g. missing quotes, bad escaping, ...). |
Yes please -- I've recently merged translations from Weblate so now is a good time. |
Just to confirm, I've updated the broken files. |
Describe the bug
Some of our localization files might have an invalid syntax, they might work, due to lax parsers, but also cause unexpected issues with other softwares:
gettext
package might ignore the text: Handling of defective .po files php-gettext/Gettext#282Besides that, as the localization is also maintained by non-technical people, it makes sense to ensure some things are not broken on the way.
Solution
Locale
class might also flag variables which were passed to it, but not used/replaced (something might be missing)The tool can be written for
stable-3_3_0
, as it's not a breaking change.What application are you using?
OJS/main
The text was updated successfully, but these errors were encountered: