Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PKP-LIB][main] #10859 Fix warning related to 'userId' and 'inviteeEmail' when adding an invitation #10860

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

defstat
Copy link
Contributor

@defstat defstat commented Jan 30, 2025

No description provided.

Copy link
Collaborator

@ewhanson ewhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @defstat!

Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using ?? operator instead of Arr::get; the Arr::get is mostly for the sake of supporting Laravel's dot notation, which is overkill here.

@asmecher asmecher merged commit 404f190 into pkp:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants