pkp/pkp-lib#9127 Restrict submission file access for global roles when dual-assigned #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
commented
Jul 4, 2023
| @@ -59,13 +63,49 @@ public function effect() | |||
| { | |||
| // Check whether the user has one of the allowed roles | |||
| // assigned. If that's the case we'll permit access. | |||
| // Get user roles grouped by context. | |||
| $userRoles = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_ACCESSIBLE_WORKFLOW_STAGES); | |||
There was a problem hiding this comment.
As far as I understand, we don't need workflow stages, which are accessible for the user here, as they also include stages accessible because of global roles, like admin or manager. Instead stage assignments should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.