Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github ref in main.yml #320

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix github ref in main.yml #320

merged 1 commit into from
Nov 22, 2024

Conversation

kaitlinnewson
Copy link
Member

@kaitlinnewson kaitlinnewson commented Nov 15, 2024

According to the docs for github.head_ref:

The head_ref or source branch of the pull request in a workflow run. This property is only available when the event that triggers a workflow run is either pull_request or pull_request_target.

@kaitlinnewson
Copy link
Member Author

@withanage Can you review this change to the GitHub actions? I noticed that some of the jobs aren't being triggered (e.g. to build the website).

@withanage withanage self-requested a review November 15, 2024 22:04
@withanage
Copy link
Member

@kaitlinnewson i reviewed the changes. the change is ok to be merged.

@kaitlinnewson
Copy link
Member Author

@withanage are you able to merge this as well? I don't have permissions on this repo.

@kaitlinnewson
Copy link
Member Author

Hi @asmecher, can you give this a second review? I'm trying to resolve the issues with the plugin compatibility site not rebuilding. Thanks!

@asmecher asmecher merged commit 917f509 into pkp:main Nov 22, 2024
1 check passed
@asmecher
Copy link
Member

Looks fine to me -- though the only material change I think is the branch name, right? In any case, Dulip's OK is what matters, and a skim looks fine from my side. Merged!

@withanage
Copy link
Member

withanage commented Nov 24, 2024

Hi @kaitlinnewson and @asmecher

Sorry @kaitlinnewson I missed the merge request.

I have seen that there is an error in the plugin-gallery in the site generation. I added the github user to pkp-plugin-cli (similar to pkp-gihtub-cations) and it should then update the other repo correctly.

https://github.com/pkp/pkp-plugin-cli/pull/10/files

@kaitlinnewson
Copy link
Member Author

@asmecher Since the GitHub Actions are pulling the package from npm, we'll need another release for the npm package to confirm the fix.

@asmecher
Copy link
Member

@kaitlinnewson and @withanage, I released a new pkp-plugin-cli package and re-ran the Plugin Gallery build; now it errors out with permission denied:
image

I suppose the script is trying to push with the github credentials you specified, Dulip, which won't work.

From the Access page in the plugin-compatibility repo, we have a single-purpose github account for that purpose:

image

I suppose there's probably a github Personal Access Token associated with the push. I can regenerate that if needed, but I suspect there are more modern ways to accomplish this since this was set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants