Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web of Science Reviewer Recognition Service plugin for OJS 3.1, update for OJS 3.4 #325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Alex-nz
Copy link

@Alex-nz Alex-nz commented Nov 26, 2024

  • Add Web of Science Reviewer Recognition Service plugin for OJS 3.1 into the plugin gallery.
  • Update version of the plugin for OJS 3.4

@Alex-nz Alex-nz closed this Nov 26, 2024
@Alex-nz Alex-nz reopened this Nov 26, 2024
@Alex-nz
Copy link
Author

Alex-nz commented Nov 26, 2024

hi team, can someone please code review this PR to add releases for the WoS RRS plugin. Previous PR for this plugin was reviewed by @bozana #301

@bozana
Copy link

bozana commented Nov 26, 2024

Hi @Alex-nz,
For your version 1.3.1.0 I would suggest that you add addRoleAssignment, function authorize, and the check if($request->getContext()->getId() != $journalId) { as in the version I reviewed before.
I also think that you should leave the version 1.3.4.1 here in the plugins.xml, because someone could already be using it, and to just add the new 1.3.4.2 version. What is actually the change from 1.3.4.1 and 1.3.4.2?
Thanks a lot!

@Alex-nz
Copy link
Author

Alex-nz commented Nov 27, 2024

Thanks for the review @bozana.

For your version 1.3.1.0 I would suggest that you add addRoleAssignment, function authorize, and the check if($request->getContext()->getId() != $journalId) { as in the version I reviewed before.

Is this critical for the approval? It's an older version of the plugin and we were hoping to simply re-brand it from Publons, without investing much time in re-writing.

I also think that you should leave the version 1.3.4.1 here in the plugins.xml, because someone could already be using it, and to just add the new 1.3.4.2 version. What is actually the change from 1.3.4.1 and 1.3.4.2?

Ok, I wasn't sure of the process here and actually was wondering if that's going to be a better way. I'll update that.

@bozana
Copy link

bozana commented Nov 27, 2024

Hi @Alex-nz, lets leave the first point as it is -- no need to invest more time into it.
Is there any difference between 1.3.4.1 and 1.3.4.2?
If no, only 1.3.4.1 could stay.
Else, once you added 1.3.4.1 version into plugins.xml again, I can merge...

@Alex-nz
Copy link
Author

Alex-nz commented Nov 27, 2024

thank you @bozana .
Sorry, I forgot to reply to the question about the difference! There is a small change to locale files only (one URL needed to be updated). No other changes. Does it warrant a new version? If so, I'll put it alongside the 1.3.4.1, not replacing it.

@Alex-nz
Copy link
Author

Alex-nz commented Nov 27, 2024

I'll update the PR tomorrow then, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants