Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRASH] wxLuaEdit at "Run wxLua program" #5

Closed
ildar opened this issue Oct 5, 2017 · 42 comments
Closed

[CRASH] wxLuaEdit at "Run wxLua program" #5

ildar opened this issue Oct 5, 2017 · 42 comments
Assignees
@pkulchenko

Comments

@ildar
Copy link

ildar commented Oct 5, 2017

Actually not just on "Run wxLua program" but maybe earlier.

$ wxLuaEdit 2>&1 | egrep -v '^$' | uniq
12:56:20: Debug: Failed to connect to session manager: SESSION_MANAGER environment variable not defined
(wxLuaEdit:28751): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar
(wxLuaEdit:28751): Gtk-WARNING **: Negative content width -6 (allocation 12, extents 9x9) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-WARNING **: Negative content height -4 (allocation 6, extents 5x5) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-WARNING **: Negative content width -12 (allocation 6, extents 9x9) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar
(wxLuaEdit:28751): Gtk-WARNING **: Negative content width -6 (allocation 12, extents 9x9) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-WARNING **: Negative content height -4 (allocation 6, extents 5x5) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-WARNING **: Negative content width -12 (allocation 6, extents 9x9) while allocating gadget (node button, owner GtkButton)
(wxLuaEdit:28751): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkScrollbar
(wxLuaEdit:28751): Gdk-CRITICAL **: The window 0xbcf7d0 already has a drawing context. You cannot call gdk_window_begin_draw_frame() without calling gdk_window_end_draw_frame() first.
(wxLuaEdit:28751): Gdk-CRITICAL **: gdk_drawing_context_get_cairo_context: assertion 'GDK_IS_DRAWING_CONTEXT (context)' failed

Could you please check? This is the git HEAD built against wxGTK git HEAD (GTK+3).
@pkulchenko
Copy link
Owner

@ildar, I don't think there is anything I can do as these look to be wxwidgets asserts and not something that wxlua would be responsible for. One way to see where they are thrown would be to compile wxwidgets with debug info (and don't strip the binaries when wxlua is built) and step through the debugger to see under what conditions they are thrown, but still, there is not much I can do and these should probably be reported (or at least discussed) in wxdev list.

@pkulchenko
Copy link
Owner

Also, I don't see any information indicating crash. I think the crash needs to be investigated separately; you can open the dump in gdb and look at the stack trace that led to the crash.

@ildar ildar mentioned this issue Oct 11, 2017
Closed
@ildar
Copy link
Author

ildar commented Oct 30, 2017 via email •
edited
Loading

@ildar
Copy link
Author

ildar commented Nov 14, 2017

wxLuaEdit.valgrind.log

@pkulchenko
Copy link
Owner

Just to copy the relevant information here:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff2864fe0 in cairo_translate () from /usr/lib64/libcairo.so.2
(gdb) bt
#0  0x00007ffff2864fe0 in cairo_translate () from /usr/lib64/libcairo.so.2
#1  0x00007ffff3bfc0d5 in ?? () from /usr/lib64/libgtk-3.so.0
#2  0x00007ffff3aa3a9f in gtk_main_do_event () from /usr/lib64/libgtk-3.so.0
#3  0x00007ffff35bf035 in ?? () from /usr/lib64/libgdk-3.so.0
#4  0x00007ffff35cf388 in ?? () from /usr/lib64/libgdk-3.so.0
#5  0x00007ffff35d0586 in ?? () from /usr/lib64/libgdk-3.so.0
#6  0x00007ffff35d0784 in ?? () from /usr/lib64/libgdk-3.so.0
#7  0x00007ffff69e44d6 in wxWindow::Update() ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#8  0x00007ffff6a1fd24 in wxStatusBar::DoUpdateStatusText(int) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#9  0x00007ffff7afb20e in wxSTEditorFrame::OnSTCUpdateUI(wxStyledTextEvent&) ()
   from /usr/lib64/libwxstedit-wxd-1.6.0.so
#10 0x00007ffff62394be in wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const () from /usr/lib64/libwx_baseu-3.1.so.1
#11 0x00007ffff645f687 in wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () from /usr/lib64/libwx_baseu-3.1.so.1
#12 0x00007ffff645f7f3 in wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) () from /usr/lib64/libwx_baseu-3.1.so.1
#13 0x00007ffff6461818 in wxEvtHandler::TryHereOnly(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#14 0x00007ffff64618a3 in wxEvtHandler::ProcessEventLocally(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#15 0x00007ffff6461905 in wxEvtHandler::ProcessEvent(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#16 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#17 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#18 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#19 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#20 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#21 0x00007ffff6c4ff78 in wxWindowBase::TryAfter(wxEvent&) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1
#22 0x00007ffff70d8551 in wxStyledTextCtrl::NotifyParent(SCNotification*) ()
   from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#23 0x00007ffff70ead15 in ?? () from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#24 0x00007ffff7108dcb in ?? () from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#25 0x00007ffff7112e98 in ?? () from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#26 0x00007ffff70ec03d in ?? () from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#27 0x00007ffff70dc856 in wxStyledTextCtrl::OnPaint(wxPaintEvent&) ()
   from /usr/lib64/libwx_gtk3u_stc-3.1.so.1
#28 0x00007ffff62394be in wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const () from /usr/lib64/libwx_baseu-3.1.so.1
#29 0x00007ffff645f687 in wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () from /usr/lib64/libwx_baseu-3.1.so.1
#30 0x00007ffff645f7f3 in wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) () from /usr/lib64/libwx_baseu-3.1.so.1
#31 0x00007ffff6461818 in wxEvtHandler::TryHereOnly(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#32 0x00007ffff64618a3 in wxEvtHandler::ProcessEventLocally(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#33 0x00007ffff6461905 in wxEvtHandler::ProcessEvent(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#34 0x00007ffff6461ae7 in wxEvtHandler::SafelyProcessEvent(wxEvent&) ()
   from /usr/lib64/libwx_baseu-3.1.so.1
#35 0x00007ffff69ec17e in wxWindow::GTKSendPaintEvents(_cairo*) ()
   from /usr/lib64/libwx_gtk3u_core-3.1.so.1

The relevant fragment from Valgrind log:

==31649== Invalid read of size 4
==31649==    at 0xA0CCFE0: cairo_translate (in /usr/lib64/libcairo.so.2.11400.4)
==31649==    by 0x8E0A0D4: ??? (in /usr/lib64/libgtk-3.so.0.2200.24)
==31649==    by 0x8CB1A9E: gtk_main_do_event (in /usr/lib64/libgtk-3.so.0.2200.24)
==31649==    by 0x93CA034: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DA387: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DB585: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DB783: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x5E3F4D5: wxWindow::Update() (in /usr/lib64/libwx_gtk3u_core-3.1.so.1.0.0)
==31649==    by 0x5E7AD23: wxStatusBar::DoUpdateStatusText(int) (in /usr/lib64/libwx_gtk3u_core-3.1.so.1.0.0)
==31649==    by 0x4F4D20D: wxSTEditorFrame::OnSTCUpdateUI(wxStyledTextEvent&) (in /usr/lib64/libwxstedit-wxd-1.6.0.so)
==31649==    by 0x65624BD: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const (in /usr/lib64/libwx_baseu-3.1.so.1.0.0)
==31649==    by 0x6788686: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) (in /usr/lib64/libwx_baseu-3.1.so.1.0.0)
==31649==  Address 0x4 is not stack'd, malloc'd or (recently) free'd
==31649== 
==31649== 
==31649== Process terminating with default action of signal 11 (SIGSEGV)
==31649==  Access not within mapped region at address 0x4
==31649==    at 0xA0CCFE0: cairo_translate (in /usr/lib64/libcairo.so.2.11400.4)
==31649==    by 0x8E0A0D4: ??? (in /usr/lib64/libgtk-3.so.0.2200.24)
==31649==    by 0x8CB1A9E: gtk_main_do_event (in /usr/lib64/libgtk-3.so.0.2200.24)
==31649==    by 0x93CA034: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DA387: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DB585: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x93DB783: ??? (in /usr/lib64/libgdk-3.so.0.2200.24)
==31649==    by 0x5E3F4D5: wxWindow::Update() (in /usr/lib64/libwx_gtk3u_core-3.1.so.1.0.0)
==31649==    by 0x5E7AD23: wxStatusBar::DoUpdateStatusText(int) (in /usr/lib64/libwx_gtk3u_core-3.1.so.1.0.0)
==31649==    by 0x4F4D20D: wxSTEditorFrame::OnSTCUpdateUI(wxStyledTextEvent&) (in /usr/lib64/libwxstedit-wxd-1.6.0.so)
==31649==    by 0x65624BD: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const (in /usr/lib64/libwx_baseu-3.1.so.1.0.0)
==31649==    by 0x6788686: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) (in /usr/lib64/libwx_baseu-3.1.so.1.0.0)

Just to confirm, this is running wxLuaEdit, not ZeroBrane Studio, right? Do you know what was done in the editor at the time of the crash? The stack trace looks believable, but I don't see any calls to update wxStatusBar, so I'm not sure why it's in the trace.

I did run into some issues with status bar updates from wxEVT_STC_PAINTED and wxEVT_STC_UPDATEUI events, but none led to crashes (although there were some drawing issues, which looks similar to your situation judging by the stack trace). You can search for these events in https://github.com/pkulchenko/ZeroBraneStudio/blob/master/src/editor/editor.lua#L1160-L1200 to check the comments and the workaround.

@ildar
Copy link
Author

ildar commented Nov 14, 2017 via email

@ildar
Copy link
Author

ildar commented Nov 17, 2017 via email •
edited
Loading

@ildar ildar mentioned this issue Nov 17, 2017
Closed
@ildar
Copy link
Author

ildar commented Feb 12, 2018 via email

@ildar
Copy link
Author

ildar commented Feb 13, 2018 via email

@pkulchenko
Copy link
Owner

So, if the issue is with wxLuaEdit, can you apply the same workaround I implemented in ZBS as described in my earlier comment?

@pkulchenko pkulchenko reopened this Feb 14, 2018
@ghost ghost mentioned this issue Mar 9, 2019
Closed
@ildar ildar mentioned this issue Jun 24, 2019
Closed
@pkulchenko pkulchenko self-assigned this Jun 24, 2019
@pkulchenko
Copy link
Owner

@ildar, can you try the change in my last comment to see if it fixes the issue?

@pkulchenko
Copy link
Owner

@ildar, actually, I checked the source code of wxLuaEdit to see how to apply the suggested solution, but I don't see any usage of wxStatusBar, so not sure why it's showing up in the stack trace. Are you running the debug or release build?

@ildar
Copy link
Author

ildar commented Jun 24, 2019 via email

@ildar
Copy link
Author

ildar commented Jun 25, 2019 •
edited
Loading

wxLua-gdb-backtrace.txt

@pkulchenko
Copy link
Owner

@ildar, thank you for the update. I don't see any reason why it would be failing in wxLua_wxFrame_SetStatusText call.

Just to confirm, are you saying that this crash happens after you make mouse-middle-click? Also, are you still running wxLuaEdit example? I don't see any status bar-related code in it, so not sure if this is a bogus stack trace or there is something else going on...

Can you try compiling and running wxwidgets/samples/stc example and using the same mouse-middle-click there to paste? I'm curious if you get the same behavior or not. If you do, I can open a wxwidgets ticket for it.

@ildar
Copy link
Author

ildar commented Jun 26, 2019 via email

@ildar
Copy link
Author

ildar commented Jun 27, 2019

wxLuaEdit-gdb-backtrace.txt

@pkulchenko
Copy link
Owner

@ildar, I'm still a bit confused about what happens. If the crash is related to middle-mouse click, then I'd try to reproduce it in the wxwidgets sample to see if the same problem exists there, in which case I can open a wxwidgets ticket.

If the crash is related to exiting the wxlua process, then I suggest re-testing on the most recent master branch, as there have been several fixes that I expect to address this issue. Let me know what you can find.

With respect to your backtrace, I check wxLuaEdit source, but I don't see wxStatusBar used anywhere there, and it looks like that method is shown in the stack trace. If you are not running the debug build, can you try compiling with the DEBUG option and then executing the same action in the application to see what stack trace is going to be reported.

@pkulchenko
Copy link
Owner

@ildar, please retest on the current master branch build; I've made several changes that allow building against the current wxwidgets master, so would be interested to see if this is fixed, as I plan to use the master branch for the next upgrade.

@ildar
Copy link
Author

ildar commented Oct 1, 2019 via email •
edited
Loading

@ildar
Copy link
Author

ildar commented Oct 1, 2019 via email •
edited
Loading

@pkulchenko
Copy link
Owner

@ildar, can you check the core dump? gdb bin/linux/x64/lua core and then bt to show the stack trace during crash. If the core file is not there, you may need to enable capturing it with ulimit -c unlimited.

@pkulchenko
Copy link
Owner

@ildar, the last gdb stacktrace you included was for LuaEdit. Do you have the similar one for ZBS? Also, does the crash happen when you click on the mid-mouse-click in the editor?

@pkulchenko
Copy link
Owner

@ildar, I tested on Ubuntu 16.04, but can't cause a crash when the mid-mouse-click is done. I get the text pasted (inconsistently a bit), but no crashes. Does the app crash when the click happens or when you close the app?

@pkulchenko
Copy link
Owner

@ildar, can you get the backtrace from gdb like you did earlier? I can't do anything with the coredump on my machine (as it needs to be processed on yours).

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@pkulchenko
Copy link
Owner

@ildar, this seems to be a GTK3 issue and may be version-specific. I see multiple reports from various applications, so it's likely doesn't have anything to do with wxlua or ZBS.

As I see DoUpdateStatusText in the trace, you may try the following patch to see if this makes it any better, but I don't have high hopes for it:

diff --git a/src/editor/editor.lua b/src/editor/editor.lua
index 6b4cac4f..7ac09a39 100644
--- a/src/editor/editor.lua
+++ b/src/editor/editor.lua
@@ -1242,7 +1242,7 @@ function CreateEditor(bare)
     function (event)
       PackageEventHandle("onEditorPainted", editor, event)

-      if ide.osname == 'Windows' then
+      if ide.osname == 'Windows' or ide.osname == 'Unix' then
         -- STC_PAINTED is called on multiple editors when they point to
         -- the same document; only update status for the active one
         if notebook:GetSelection() == notebook:GetPageIndex(editor) then
@@ -1288,7 +1288,7 @@ function CreateEditor(bare)

       PackageEventHandle("onEditorUpdateUI", editor, event)

-      if ide.osname ~= 'Windows' then updateStatusText(editor) end
+      if ide.osname ~= 'Windows' and ide.osname ~= 'Unix' then updateStatusText(editor) end

       editor:GotoPosDelayed()
       updateBraceMatch(editor)

@pkulchenko
Copy link
Owner

BTW, what's the GTK version on your machine and what does uname -a return?

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@pkulchenko
Copy link
Owner

GTK version is 3.22.24
libgtk+3-3.24.11-alt1.x86_64

Your earlier message reported a slightly older GTK version.

The proposed patch didn't help BTW.

That's too bad, as I don't have any other suggestion short of not using the middle button to paste the text ;(. Not sure what else can be done assuming this is indeed a GTK issue, which is what it looks like. You can try upgrading to a newer version of GTK if there is one or rebuilding using GTK2, which doesn't seem to suffer from this issue.

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@pkulchenko
Copy link
Owner

@ildar, one more suggestion to try. Can you see if you can crash this minimal sample:

require "wx"
local frame = wx.wxFrame(wx.NULL, wx.wxID_ANY, "STC Demo",
  wx.wxDefaultPosition, wx.wxSize(450, 450), wx.wxDEFAULT_FRAME_STYLE )
local e = wxstc.wxStyledTextCtrl(frame, wx.wxID_ANY,
  wx.wxDefaultPosition, wx.wxSize(0, 0), wx.wxBORDER_STATIC)

e:SetLexer(wxstc.wxSTC_LEX_LUA)
e:SetProperty("fold", "1")

frame:Show(true)
wx.wxGetApp():MainLoop()

@ildar
Copy link
Author

ildar commented Oct 2, 2019 via email

@pkulchenko
Copy link
Owner

@ildar, interesting. Then you can try two things to see if you can get any of the two to crash:

(1) test the following example: https://github.com/pkulchenko/wxlua/blob/master/wxLua/samples/editor.wx.lua
(2) apply the following patch (effectively disabling both events):

diff --git a/src/editor/editor.lua b/src/editor/editor.lua
index 6b4cac4f..ebd15170 100644
--- a/src/editor/editor.lua
+++ b/src/editor/editor.lua
@@ -1240,6 +1240,7 @@ function CreateEditor(bare)
   -- where refresh of R/W and R/O status in the status bar is delayed.
   editor:Connect(wxstc.wxEVT_STC_PAINTED,
     function (event)
+      do return end
       PackageEventHandle("onEditorPainted", editor, event)

       if ide.osname == 'Windows' then
@@ -1270,6 +1271,7 @@ function CreateEditor(bare)
   editor.processedUpdateContent = 0
   editor:Connect(wxstc.wxEVT_STC_UPDATEUI,
     function (event)
+      do return end
       -- some of UPDATEUI events may be triggered as the result of editor updates
       -- from subsequent events (like PAINTED, which happens in documentmap plugin).
       -- the reason for the `processed` check is that it is not possible

@ildar
Copy link
Author

ildar commented Oct 3, 2019 via email

@pkulchenko
Copy link
Owner

(2) I couldn't crash this. Yahoo, we have a workaround here!

That's good; now let's figure out which one of the handlers is causing it. Can you comment one-by-one to see if this is UPDATEUI or PAINTED? I suspect it is UPDATEUI and if it is, can you comment out if ide.osname ~= 'Windows' then updateStatusText(editor) end line in it and see if you can still crash it?

If it works, then try the following patch:

diff --git a/src/editor/editor.lua b/src/editor/editor.lua
index 57ae5f82..29da2cfb 100644
--- a/src/editor/editor.lua
+++ b/src/editor/editor.lua
@@ -1288,7 +1288,13 @@ function CreateEditor(bare)

       PackageEventHandle("onEditorUpdateUI", editor, event)

-      if ide.osname ~= 'Windows' then updateStatusText(editor) end
+      if ide.osname ~= 'Windows' then
+        if ide.osname == "Unix" then
+          editor:DoWhenIdle(function() updateStatusText(editor) end)
+        else
+          updateStatusText(editor)
+        end
+      end

If it doesn't work (you can still crash it after commenting out line with updateStatusText call, can you also comment out the line with updateBraceMatch(editor) below in the same event handler?

@pkulchenko
Copy link
Owner

@ildar, this is a more complete patch:

diff --git a/src/editor/editor.lua b/src/editor/editor.lua
index 57ae5f82..6fba4822 100644
--- a/src/editor/editor.lua
+++ b/src/editor/editor.lua
@@ -1238,17 +1238,17 @@ function CreateEditor(bare)
   -- brackets or backspace is used (very slow screen repaint with 0.5s delay).
   -- Moving it to PAINTED event creates problems on OSX (using wx2.9.5+),
   -- where refresh of R/W and R/O status in the status bar is delayed.
+  -- PAINTED is better, as it allows to track INS vs OVR and R/O vs R/W status.
   editor:Connect(wxstc.wxEVT_STC_PAINTED,
     function (event)
       PackageEventHandle("onEditorPainted", editor, event)
 
-      if ide.osname == 'Windows' then
-        -- STC_PAINTED is called on multiple editors when they point to
-        -- the same document; only update status for the active one
-        if notebook:GetSelection() == notebook:GetPageIndex(editor) then
-          updateStatusText(editor)
-        end
+      local doc = ide:GetDocument(editor)
+      if doc and doc:IsActive() then
+        editor:DoWhenIdle(function() updateStatusText(editor) end)
+      end
 
+      if ide.osname == 'Windows' then
         if edcfg.usewrap ~= true and editor:AutoCompActive() then
           -- showing auto-complete list leaves artifacts on the screen,
           -- which can only be fixed by a forced refresh.
@@ -1288,8 +1288,6 @@ function CreateEditor(bare)
 
       PackageEventHandle("onEditorUpdateUI", editor, event)
 
-      if ide.osname ~= 'Windows' then updateStatusText(editor) end
-
       editor:GotoPosDelayed()
       updateBraceMatch(editor)
       local minupdated

I still need to test it on macOS, but it works as expected in all scenarios on Windows, so I'd be interested if you run into any problems with it on Linux. Thanks.

@ildar
Copy link
Author

ildar commented Oct 4, 2019 via email

@pkulchenko
Copy link
Owner

Sounds good. The changes also look good on macOS, so I'll be merging them into the upgrade branch shortly.

The issue still appears to be with wxwidgets somewhere, but at least there is a workaround for it.

pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Oct 4, 2019
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
34c5303 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Oct 18, 2019
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
acda07d 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Dec 12, 2019
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
80365fc 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Dec 13, 2019
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
7b99ca4 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Jan 9, 2020
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
5d94b3e 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
pkulchenko added a commit to pkulchenko/ZeroBraneStudio that referenced this issue Feb 3, 2020
@pkulchenko
Added workaround for Linux crash on middle mouse click in the editor (p…
826cc5c 
…kulchenko/wxlua#5).

This also fixed R/O vs R/W status update on macOS.
@pkulchenko
Copy link
Owner

@ildar, FWIW, there was a very similar wxwidgets issue that was fixed for Windows (https://trac.wxwidgets.org/ticket/18451); I suspect it could have affected Linux as well causing the problem you saw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkulchenko pkulchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkulchenko @ildar