fix(state-variables): lifting to ST from predicates had an erroneous …

…case. Transformation of negative condition was incorrect.
plaans · May 1, 2024 · 84ff4cc · 84ff4cc
1 parent b29a949
commit 84ff4cc
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/planning/planning/src/chronicles/preprocessing/state_variables.rs b/planning/planning/src/chronicles/preprocessing/state_variables.rs
@@ -654,7 +654,6 @@ fn lift(pb: &mut Problem, group: &SubstitutionGroup) {
                     Ok(false) => {
                         // transform   [s,t] (loc r l) == false  into
                         //    [s,t] loc r == ?x    and      ?x != l
-                        let forbidden_value = cond.state_var.args.pop().unwrap();
                         let var_type = return_type(&cond.state_var.fluent);
                         let var = pb.context.model.new_optional_sym_var(
                             var_type,
@@ -663,7 +662,7 @@ fn lift(pb: &mut Problem, group: &SubstitutionGroup) {
                         );
                         created_variables.push(var.into());
                         cond.value = var.into();
-                        ch.constraints.push(Constraint::neq(var, forbidden_value));
+                        ch.constraints.push(Constraint::neq(var, value));
                     }
                     Err(_) => unreachable!("State variable wrongly identified as substitutable"),
                 }