-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planning): Extend symmetry breaking to numeric planning problems #157
Conversation
350a52d
to
da8ce5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are only missing a proper condition ID for the dynamically introduced conditions. (Note that I indeed ran into this problem last week where I could not make sense of what as behind this number).
planning/planners/src/encode.rs
Outdated
{ | ||
// numeric increase coherence constraints | ||
let span = tracing::span!(tracing::Level::TRACE, "numeric increase coherence"); | ||
let _span = span.enter(); | ||
let mut num_numeric_increase_coherence_constraints = 0; | ||
let mut next_cond_id = 10000; // TODO: use a proper ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: that having 10000 conditions is not completely unrealistic as well.
No description provided.