Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning): Extend symmetry breaking to numeric planning problems #157

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

arbimo
Copy link
Member

@arbimo arbimo commented Dec 5, 2024

No description provided.

planning/planners/src/encode/symmetry.rs Show resolved Hide resolved
planning/planners/src/encoding.rs Outdated Show resolved Hide resolved
Copy link
Member Author

@arbimo arbimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are only missing a proper condition ID for the dynamically introduced conditions. (Note that I indeed ran into this problem last week where I could not make sense of what as behind this number).

{
// numeric increase coherence constraints
let span = tracing::span!(tracing::Level::TRACE, "numeric increase coherence");
let _span = span.enter();
let mut num_numeric_increase_coherence_constraints = 0;
let mut next_cond_id = 10000; // TODO: use a proper ID
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: that having 10000 conditions is not completely unrealistic as well.

@arbimo arbimo merged commit f4c80b5 into master Dec 17, 2024
11 checks passed
@arbimo arbimo deleted the feat/num-sym-break branch December 17, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants