Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): added kube score check action #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rdiazx
Copy link

@rdiazx rdiazx commented May 12, 2022

@rdiazx rdiazx requested review from w-le, pkheav and caspiano May 12, 2022 20:51
@rdiazx
Copy link
Author

rdiazx commented May 12, 2022

Hi @caspiano , I added a new action to the workflow, and found out that an existing (kube-linter) action is failing. It's not finding the "../results/kube-linter.sarif" file. it looks like the file is not being generated. Any idea.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@caspiano
Copy link
Contributor

caspiano commented May 16, 2022

@rdiazx I removed the kube-lint action step, I suspect either there were no sarif files produced and no check to see if they were present before trying to upload, or the path to the sarif file was wrong

@caspiano
Copy link
Contributor

@rdiazx if you can, can you re-add kubelint, and only run the upload step if there's a sarif file present?

@caspiano
Copy link
Contributor

It doesn't look like this is producing any expected output, whereas kube-lint was creating suggestions, see the security tab of this repo.
The files that the action is running on seem to be just the base chart and values file.

@caspiano caspiano added focus: devops Focus on DevOps/Infra type: enhancement new feature or request type: maintenance requires maintenance labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: devops Focus on DevOps/Infra type: enhancement new feature or request type: maintenance requires maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants