Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up frontend #464

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Clean up frontend #464

merged 3 commits into from
Mar 20, 2024

Conversation

ToddKerpelman
Copy link
Contributor

@ToddKerpelman ToddKerpelman commented Mar 16, 2024

  1. Ran npm audit fix so that most of the security warnings are gone. (The react-tools one is a bit of a red herring. See Help, npm audit says I have a vulnerability in react-scripts! facebook/create-react-app#11174)
  2. Removed a few unused variables, added a useCallback dependency to make react happy
  3. A bunch of unintentional changes thanks to prettier
  4. Added /python/venv to the gitignore file which isn't a frontend issue, but hey...

I might recommend trying to npm install and run the frontend version of this branch locally, just to make sure it doesn't just work on my machine.

@ToddKerpelman ToddKerpelman marked this pull request as ready for review March 18, 2024 20:43
Copy link
Contributor

@phoenixy1 phoenixy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested as suggested, both docker and non-docker, confirmed i could complete link and make api calls

@ToddKerpelman ToddKerpelman merged commit 0ab0d3a into master Mar 20, 2024
SpencerHHurst pushed a commit to SpencerHHurst/quickstart that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants